From 36da3ff763687eab86a35e1019995dd1fb369b0d Mon Sep 17 00:00:00 2001 From: guill Date: Mon, 14 Sep 2026 21:32:24 -0700 Subject: [PATCH] Temporarily disable testing with `--enable-assets` (#16334) This is just to unblock other work and reduce frustration while we address the flaky tests. --- tests-unit/assets_test/conftest.py | 3 +++ tests-unit/assets_test/test_event_log_sites.py | 2 ++ tests/execution/test_execution.py | 3 ++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tests-unit/assets_test/conftest.py b/tests-unit/assets_test/conftest.py index 387e3cf76..201d86cee 100644 --- a/tests-unit/assets_test/conftest.py +++ b/tests-unit/assets_test/conftest.py @@ -101,6 +101,9 @@ def comfy_url_and_proc(comfy_tmp_base_dir: Path, request: pytest.FixtureRequest) - autoscan disabled Returns (base_url, process, port) """ + # TODO: re-enable once the --enable-assets subprocess runs stop flaking. + pytest.skip("assets subprocess tests temporarily disabled") + port = _free_port() db_url = request.config.getoption("--db-url") if not db_url: diff --git a/tests-unit/assets_test/test_event_log_sites.py b/tests-unit/assets_test/test_event_log_sites.py index 499713856..0880ca306 100644 --- a/tests-unit/assets_test/test_event_log_sites.py +++ b/tests-unit/assets_test/test_event_log_sites.py @@ -43,6 +43,8 @@ def run_quick_startup(tmp_path: Path, *flags: str) -> str: return result.stdout + result.stderr +# TODO: re-enable once the --enable-assets startup runs stop flaking. +@pytest.mark.skip(reason="assets startup tests temporarily disabled") @pytest.mark.parametrize( ("hashing_flag", "expected"), [ diff --git a/tests/execution/test_execution.py b/tests/execution/test_execution.py index 312a7a15c..b8b3e856f 100644 --- a/tests/execution/test_execution.py +++ b/tests/execution/test_execution.py @@ -482,7 +482,8 @@ class TestExecution: { "extra_args" : ["--cache-classic"], "should_cache_results" : True }, { "extra_args" : ["--cache-lru", 100], "should_cache_results" : True }, { "extra_args" : ["--cache-none"], "should_cache_results" : False }, - {"extra_args": ["--enable-assets"], "should_cache_results": True, "assets": True}, + # TODO: re-enable once the --enable-assets execution runs stop flaking. + # {"extra_args": ["--enable-assets"], "should_cache_results": True, "assets": True}, ]) def server(self, args_pytest, request, tmp_path_factory): # Start server