fix/server-mode-admin-auth
1
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
780ff1f6cf |
fix(tts): Vietnamese consistency — Voice vs Audiobook divergences (#1142)
* fix(tts): Vietnamese consistency — Voice vs Audiobook divergences (#1139) Three root causes behind "Vietnamese Voice generation is inconsistent compared to Audiobook": 1. Numbers: num2words' vi cardinals are wrong for 2001-2099 (misused "lẻ": 2024 → "hai nghìn lẻ hai mươi bốn") and vi has no year form, so normalization mangled the years the engine used to read natively. Vietnamese now keeps its digits, and _num2words_lang's display-name path now gates on _NUM2WORDS_LANGS like the ISO path (the loophole that let "Vietnamese" bypass the vetting "vi" would have failed). 2. Seed: the longform resolver fetched a profile's pinned seed but only the cache signature ever used it — book renders ran unseeded. Both longform synth wrappers now seed torch per segment via the new pure segment_seed(base_seed, text) helper (crc32-decorrelated, order- and cache-independent, mirroring /generate's used_seed + i). 3. Quality preset: the audiobook synth inherited num_step=32 / guidance_scale=2.0 from model-config defaults by accident of omission while /generate defaults to 16 — the main audible gap. Now explicit (LONGFORM_NUM_STEP / LONGFORM_GUIDANCE_SCALE), pinned by a test so upstream default drift can't silently change books. The Voice-page fast default (16) is deliberately unchanged. Also (issue part 3): the finished audiobook's player + Download link lived in component useState and evaporated on tab switch — the last render's filename is now store-backed and persisted. Regression tests fail-before/pass-after (verified by stashing the fix): vi digit passthrough + vetted-set gate invariant; segment_seed + seeding in both synth branches + explicit preset kwargs; lastOutput store round-trip. Full backend suite 3004 passed; frontend 1237 passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(ui): loadProject clears lastOutput; document longform seeding contracts (review) Review-bot findings on #1142, evaluated: - FIXED (Greptile P1 "Output Escapes Its Project" + CodeRabbit): loadProject now resets lastOutput like newProject already did, so loading project B never presents A's finished render as B's output. Regression test added (set lastOutput → loadProject → cleared). - REFUTED (P1 "Global RNG Races Between Workers"): the exposure is identical to /generate's existing #526 seeding — generation.py calls torch.manual_seed on the same global RNG inside the same GPU pool, and has since that PR. The pool is 1 worker on MPS/CPU and small-VRAM CUDA (model_manager._pick_gpu_workers), where determinism is strict; a >1-worker CUDA pool is best-effort for BOTH paths. A race-free fix means threading a per-call torch.Generator through the model's samplers app-wide (covering /generate too) — out of scope for this PR and pointless to do one-sided. Contract now documented on _seed_segment_rng. - REFUTED (P2 "Repeated Text Reuses One Seed"): identical takes for identical repeated lines is the pipeline's shipped semantic — the content-addressed SegmentCache (segment_cache_key hashes text + voice sig, not position) already replays one WAV for every identical span — and seeding only activates when the user pinned a seed, i.e. asked for reproducibility. Position-based keys would shift every later span's seed on a one-paragraph insert, breaking the cache-independent partial re-render guarantee. Documented on segment_seed. - DECLINED (P2 "Persisted Filename Can Outlive File"): longform outputs in OUTPUTS_DIR are not auto-pruned (prune_cache_dir bounds only longform_cache), so a dangling name requires manual deletion; auto-clearing on an <audio> error would instead wipe a valid link whenever the backend is briefly down at mount. Projects → Audiobooks stays the authoritative library. Also rebased onto main past #1141 (CHANGELOG resolved keeping both Unreleased→Fixed entries, this PR's on top). Affected suites: 264 passed; frontend format clean, 1245 tests passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: mergetest <nizam4103@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> |