Palash Debnath
a23e69d014
The repository was renamed. 724 references across 59 files now point at the new URL — README badges, docs, install guides, the updater's releases API call, CONTRIBUTING, the Colab link and the probe harness. GitHub redirects the old URLs, so nothing was broken in the meantime. Deliberately NOT renamed, because each breaks something on a user's machine: the Tauri bundle identifier (the path to every existing user's data), /usr/lib/omnivoice-studio and the compose container names, and the published Docker image paths. The image path needed a code change to STAY still: docker.yml derived it from github.repository, so the next build would have published to ghcr.io/debpalash/voicestudio while Docker Hub, a hardcoded literal, stayed put — everyone pulling the documented GHCR path would have kept receiving the last pre-rename image forever. It is now pinned, with a test that fails if it ever derives from the repo name again. Also makes the probe's repo-name assertion shape-based: it hardcoded the old name and failed on every PR after the rename while the code it tests worked perfectly.
64 lines
2.5 KiB
Python
64 lines
2.5 KiB
Python
"""A published image path is a promise, not a mirror of the repo name.
|
|
|
|
When the repository was renamed to `VoiceStudio`, `docker.yml` derived its
|
|
GHCR path from ``${{ github.repository }}`` — so the next build would have
|
|
started publishing to ``ghcr.io/debpalash/voicestudio`` while Docker Hub, a
|
|
hardcoded literal, stayed exactly where it was. Every user pulling the
|
|
documented GHCR path would have kept receiving the last pre-rename image
|
|
indefinitely: no error, no warning, a channel that quietly stopped updating.
|
|
|
|
Renaming a published image is a deliberate migration (publish to both, document
|
|
the move, retire the old one). It must never be a side effect of renaming the
|
|
repository, which is why the path is pinned and why that is pinned here.
|
|
"""
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
yaml = pytest.importorskip("yaml")
|
|
|
|
ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
|
WORKFLOW = os.path.join(ROOT, ".github", "workflows", "docker.yml")
|
|
|
|
|
|
def _env():
|
|
with open(WORKFLOW, encoding="utf-8") as fh:
|
|
return yaml.safe_load(fh)["env"]
|
|
|
|
|
|
def test_the_ghcr_path_does_not_follow_the_repository_name():
|
|
image = _env()["IMAGE_NAME"]
|
|
assert "github.repository" not in str(image), (
|
|
"IMAGE_NAME derives from the repo name again — renaming the repository "
|
|
"would silently move published images and strand everyone pulling the "
|
|
"documented path"
|
|
)
|
|
assert image == "debpalash/omnivoice-studio"
|
|
|
|
|
|
def test_the_two_registries_publish_the_same_name():
|
|
# They are separate registries with independent naming, and Docker Hub's is
|
|
# a literal. If GHCR drifts from it, the docs can only be right about one.
|
|
env = _env()
|
|
ghcr_name = str(env["IMAGE_NAME"]).split("/")[-1]
|
|
hub_name = str(env["DOCKERHUB_IMAGE"]).split("/")[-1]
|
|
assert ghcr_name == hub_name, (
|
|
f"GHCR publishes '{ghcr_name}' but Docker Hub publishes '{hub_name}' — "
|
|
f"one of the documented pull commands is wrong"
|
|
)
|
|
|
|
|
|
def test_the_docs_name_the_path_that_is_actually_published():
|
|
"""Docs drift here is invisible: a wrong pull command fails only for users."""
|
|
env = _env()
|
|
published = f"ghcr.io/{env['IMAGE_NAME']}"
|
|
for rel in ("docs/install/docker.md", "deploy/dockerhub-overview.md"):
|
|
path = os.path.join(ROOT, rel)
|
|
if not os.path.isfile(path):
|
|
continue
|
|
text = open(path, encoding="utf-8").read()
|
|
if "ghcr.io/" not in text:
|
|
continue
|
|
assert published in text, f"{rel} does not document {published}"
|