5a28c04c44
Five hand-maintained version literals (pyproject, Cargo.toml, tauri.conf.json,
package.json, version.py) drifting is what shipped a 0.3.6 build calling itself
0.3.5 (package.json lagged; the frozen backend's literal lagged). Collapse to
one canonical source.
- frontend/package.json is canonical: vite already injects __APP_VERSION__ from
it (first-run setup footer + bug reports).
- tauri.conf.json now reads its bundle version from it ("version":
"../package.json", a supported Tauri v2 feature) — the MSI/dmg/updater version
can no longer drift from the UI. Removes the most error-prone literal.
- Cargo.toml + pyproject.toml + version.py's _FALLBACK_VERSION remain as
toolchain-required CI-guarded mirrors, bumped in lockstep from the canonical.
- release.yml: the preview-stamp and version-bump jobs now read/write
package.json (the canonical) and no longer touch the derived tauri.conf.json.
- tests/test_app_version.py: new test_tauri_version_derives_from_package_json
guards the path; the lockstep test now checks the mirrors against the
canonical package.json.
- CLAUDE.md versioning rule updated to document the single-source model.
6 version tests pass.
Co-authored-by: mergetest <test@local>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
94 lines
3.9 KiB
Python
94 lines
3.9 KiB
Python
"""The runtime app version must come from package metadata, not a stale literal
|
|
(prevents the recurring "0.4.0"/"0.2.7" drift — Greptile #145)."""
|
|
import re
|
|
from importlib.metadata import version
|
|
|
|
from core.version import APP_VERSION
|
|
|
|
|
|
def test_app_version_is_semver():
|
|
assert re.match(r"^\d+\.\d+\.\d+", APP_VERSION), APP_VERSION
|
|
|
|
|
|
def test_app_version_matches_installed_package_metadata():
|
|
# In any synced env the package is installed; APP_VERSION must equal it
|
|
# (i.e. it's read from pyproject, not hardcoded).
|
|
assert APP_VERSION == version("omnivoice")
|
|
|
|
|
|
def test_tauri_version_derives_from_package_json():
|
|
"""tauri.conf.json must NOT carry its own version literal — it derives from
|
|
package.json (Tauri v2 ``"version": "../package.json"``). package.json is the
|
|
single source of truth; a re-hardcoded literal here is exactly the drift that
|
|
shipped a 0.3.6 bundle calling itself 0.3.5."""
|
|
import json
|
|
from pathlib import Path
|
|
|
|
root = Path(__file__).resolve().parents[1]
|
|
tauri_conf = json.loads((root / "frontend/src-tauri/tauri.conf.json").read_text())
|
|
assert tauri_conf["version"] == "../package.json", (
|
|
"tauri.conf.json must derive its version from package.json "
|
|
f'(expected "../package.json", got {tauri_conf["version"]!r})'
|
|
)
|
|
|
|
|
|
def test_all_version_files_in_lockstep():
|
|
"""``frontend/package.json`` is the SINGLE SOURCE OF TRUTH for the app
|
|
version: vite injects ``__APP_VERSION__`` from it (first-run footer + every
|
|
bug report), and tauri.conf.json reads its bundle version from it
|
|
(``"version": "../package.json"``).
|
|
|
|
The other three declarations are toolchain-required CI-guarded mirrors —
|
|
Cargo.toml + pyproject.toml (cargo/uv need a literal) and
|
|
backend/core/version.py's ``_FALLBACK_VERSION`` (the frozen-backend last
|
|
resort, whose drift to "0.3.5" is why the v0.3.6 build reported 0.3.5). The
|
|
release.yml version-bump job bumps the canonical and these mirrors together;
|
|
catch any drift here in CI.
|
|
"""
|
|
from pathlib import Path
|
|
|
|
root = Path(__file__).resolve().parents[1]
|
|
|
|
def _toml_version(p: Path) -> str:
|
|
return re.search(r'(?m)^version\s*=\s*"([^"]+)"', p.read_text()).group(1)
|
|
|
|
def _named_literal(p: Path, name: str) -> str:
|
|
return re.search(rf'(?m)^{name}\s*=\s*"([^"]+)"', p.read_text()).group(1)
|
|
|
|
import json
|
|
|
|
canonical = json.loads((root / "frontend/package.json").read_text())["version"]
|
|
mirrors = {
|
|
"pyproject.toml": _toml_version(root / "pyproject.toml"),
|
|
"Cargo.toml": _toml_version(root / "frontend/src-tauri/Cargo.toml"),
|
|
"core/version.py": _named_literal(root / "backend/core/version.py", "_FALLBACK_VERSION"),
|
|
}
|
|
drifted = {k: v for k, v in mirrors.items() if v != canonical}
|
|
assert not drifted, f"version mirrors drifted from package.json={canonical!r}: {drifted}"
|
|
|
|
|
|
def test_fallback_version_resolves_to_pyproject():
|
|
"""When package metadata is unavailable (frozen build / raw checkout), the
|
|
version must still resolve to pyproject — never the stale literal that made
|
|
the v0.3.6 build report "0.3.5"."""
|
|
from pathlib import Path
|
|
|
|
from core.version import _fallback_version
|
|
|
|
root = Path(__file__).resolve().parents[1]
|
|
pyproject = re.search(
|
|
r'(?m)^version\s*=\s*"([^"]+)"', (root / "pyproject.toml").read_text()
|
|
).group(1)
|
|
assert _fallback_version() == pyproject
|
|
|
|
|
|
def test_frozen_build_collects_package_metadata():
|
|
"""backend.spec must copy_metadata('omnivoice') so the frozen backend reads
|
|
its real version via importlib.metadata instead of the fallback literal."""
|
|
from pathlib import Path
|
|
|
|
spec = (Path(__file__).resolve().parents[1] / "backend.spec").read_text()
|
|
assert (
|
|
"copy_metadata('omnivoice')" in spec or 'copy_metadata("omnivoice")' in spec
|
|
), "backend.spec must copy_metadata('omnivoice') (frozen-build version reporting)"
|