b8cc0de44a
Two robustness fixes that share the failure taxonomy: - Video downloads (#554 douyin "Unsupported URL", #536 "Broken pipe"): yt-dlp's raw error surfaced with no next step. classify() now names UNSUPPORTED_VIDEO_URL (non-downloadable link shape — paste a direct video page or drop a file) and VIDEO_DOWNLOAD_NETWORK (transient CDN/network drop — just retry; the partial download is already cleaned up), each with an actionable hint. yt-dlp is on a current pin, so this is graceful classification, not a dependency bump. - "No module named 'encodings'" (relocated/copied/restored venv whose interpreter can't bootstrap its stdlib — exit 1, not 106): slipped BOTH #314 self-heal matchers, so the user saw the error forever. Widen backend_exit_indicates_broken_venv to also match the full quoted phrase, routing it into the existing rebuild-once self-heal. Kept narrow so an app-level import of an 'encodings'-prefixed package can't trigger a rebuild. Plus a BROKEN_VENV hint for the case where the rebuild itself can't run. Tests: classify() maps the 3 new classes with hints (a generic reason still ""), and the 'encodings'-prefixed-package negative guard holds; the Rust matcher test gains the encodings positive + negative cases. 5 pytest passed; the matcher is compiled by CI's Tauri shell check. Co-authored-by: mergetest <test@local> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
69 lines
3.0 KiB
Python
69 lines
3.0 KiB
Python
"""ASR-robustness failure classification (#551 / #549).
|
|
|
|
The dub/transcribe "no segments" toast is only actionable if `classify()` names
|
|
the failure class so `build_failure()` can attach a hint. These assert the two
|
|
new taxonomy classes added for the ASR-robustness fix map to a non-empty hint.
|
|
"""
|
|
from core import failure
|
|
|
|
|
|
def test_classify_compute_type_unsupported():
|
|
# The exact CTranslate2 message on a GPU without efficient fp16 (#551).
|
|
reason = (
|
|
"Requested float16 compute type, but the target device or backend do "
|
|
"not support efficient float16 computation"
|
|
)
|
|
assert failure.classify(reason) == "COMPUTE_TYPE_UNSUPPORTED"
|
|
evt = failure.build_failure(reason, stage="transcribe", include_diagnostic=False)
|
|
assert evt["docs_topic"] == "COMPUTE_TYPE_UNSUPPORTED"
|
|
assert evt["hint"], "compute-type failure must carry an actionable hint"
|
|
|
|
|
|
def test_classify_transformers_import():
|
|
# The transformers ASR-pipeline import failure (#549).
|
|
assert failure.classify("Could not import module 'AutoFeatureExtractor'") == (
|
|
"TRANSFORMERS_IMPORT"
|
|
)
|
|
# Substring match on the bare class name too (case-insensitive).
|
|
assert failure.classify("AutoFeatureExtractor failed to load") == "TRANSFORMERS_IMPORT"
|
|
evt = failure.build_failure(
|
|
"Could not import module 'AutoFeatureExtractor'",
|
|
stage="transcribe",
|
|
include_diagnostic=False,
|
|
)
|
|
assert evt["hint"], "transformers-import failure must carry an actionable hint"
|
|
|
|
|
|
def test_classify_video_download_classes():
|
|
# #554: a non-downloadable link shape → actionable "paste a direct video URL".
|
|
assert failure.classify("Unsupported URL: https://www.douyin.com/discover") == (
|
|
"UNSUPPORTED_VIDEO_URL"
|
|
)
|
|
# #536: a transient mid-download drop → "just retry".
|
|
assert failure.classify("Unable to download video: [Errno 32] Broken pipe") == (
|
|
"VIDEO_DOWNLOAD_NETWORK"
|
|
)
|
|
assert failure.classify("Connection reset by peer") == "VIDEO_DOWNLOAD_NETWORK"
|
|
for cls, reason in (
|
|
("UNSUPPORTED_VIDEO_URL", "Unsupported URL: x"),
|
|
("VIDEO_DOWNLOAD_NETWORK", "Unable to download video: Broken pipe"),
|
|
):
|
|
evt = failure.build_failure(reason, stage="download", include_diagnostic=False)
|
|
assert evt["docs_topic"] == cls
|
|
assert evt["hint"], f"{cls} must carry an actionable hint"
|
|
|
|
|
|
def test_classify_broken_venv_encodings():
|
|
# The relocated/corrupted-venv stdlib-bootstrap failure → BROKEN_VENV (the
|
|
# Rust self-heal rebuilds it; this names the class for the toast).
|
|
assert failure.classify("ModuleNotFoundError: No module named 'encodings'") == (
|
|
"BROKEN_VENV"
|
|
)
|
|
# ...but an app-level import of an 'encodings'-prefixed package must NOT.
|
|
assert failure.classify("No module named 'encodings_helper'") == ""
|
|
|
|
|
|
def test_classify_generic_still_empty():
|
|
# A genuinely unknown reason must still classify to "" (no false hint).
|
|
assert failure.classify("some totally unrelated failure") == ""
|