* feat(demos): ship the demo audio and video the app already advertises Every demo asset in the app was a dead link on anything but a Mac. `personalities.py` has carried a `preview_url` for each of the seven voice-design presets since they were added; DictationDemo.jsx posts three bundled WAVs to /transcribe so the feature can be shown without microphone permission; the Dub workspace reads a manifest and plays a source video plus four dubbed languages. None of those files were committed, because the tooling that renders them (scripts/build_demos.sh, scripts/build_dub_demo.sh) hard- requires macOS `say` — it even carries a `TODO: add espeak-ng path for Linux contributors`. So the presets returned 404, the replay buttons did nothing, and the dubbing demo never loaded. Rendered with VoiceStudio's own engine, which runs wherever the app does: - 7 voice-design previews (2.2 MB) - 3 dictation replay clips (1.1 MB) — verified by transcribing them back: the conversational and French clips round-trip exactly - dubbing demo: source + 4 dubbed videos with subtitles and manifest (9.6 MB) Tooling fixes this turned up: - build_dub_demo.sh wrote to backend/assets/demo/dubbing, but main.py mounts backend/assets/samples at /demo_audio — so the frontend's /demo_audio/demo/dubbing/manifest.json could never have resolved even after a successful Mac build. Output moved under the mount. - `say` is now the fallback rather than the requirement: the new scripts/render_dub_demo_audio.py renders the five tracks with the engine and the shell script picks them up. - The five demo paragraphs lived in two files. They are now one JSON both read — two copies is one edit away from a video whose subtitles disagree with it. - render_demos_omnivoice.py peak-normalized, which a single-sample transient defeats: the Helpdesk preset landed at -30 dB RMS against -17 dB for its neighbours, so the preview row played at wildly different volumes. Now EBU R128 at -18 LUFS with a -1.5 dBTP ceiling. - …and pinning the output rate, because loudnorm resamples to 192 kHz internally and writes there unless told otherwise, which turned 2.1 MB of previews into 17.5 MB of identical-sounding audio. - update_manifest() looked for a manifest at a path nothing writes, so it always printed "not found" and did nothing. - Dictation is rendered here now too. It was excluded on the grounds that `say` was good enough and engine TTS was overkill — true only on macOS. tests/test_demo_assets_exist.py resolves every advertised URL against the directory main.py actually mounts, and checks each dubbing subtitle matches the script its manifest entry claims. A missing static file is not an import error and not a failing request; nothing would have caught this otherwise. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(changelog): stamp the demo-asset entries with their PR ref Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(demos): watermark rendered demo audio, and harden the render scripts Review findings on #1517: - Greptile P1: the renderers wrote engine output straight to disk, so a re-render shipped demo audio with no provenance mark. These clips play back to users as VoiceStudio output — they are synthetic audio leaving the app like any other, and now go through mark_synthetic (#1169), the one chokepoint every producing route uses. It runs on the file AFTER loudnorm, since loudnorm re-encodes what it is handed, and says so loudly when marking is unavailable rather than committing an unmarked asset. The dubbing renderer shares the same helper. - CodeRabbit: build_dub_demo.sh checked only source.src.wav before deciding it could run without macOS `say`, so a Linux or Windows run with four of five tracks present reached a missing one, called `say`, and left a half-built bundle. It now requires all five. - CodeRabbit: shutil.move over an existing path delegates to os.rename, which raises FileExistsError on Windows — os.replace overwrites atomically everywhere. - CodeRabbit: the preview test discovered presets in a parametrize argument, importing app code at collection time and leaving core.personalities in sys.modules for later tests. Discovery moved into the test body. CI: the rendered dub bundle's zh/ja subtitles, its manifest and the script source are dubbing CONTENT, not UI strings — allowlisted in test_no_hardcoded_cjk.py with that justification. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(demos): a render that cannot be watermarked fails instead of warning CodeRabbit and Greptile, #1517: mark_synthetic degrades rather than raising — correct for generation, wrong for a render script, whose whole job is to produce files a human then commits. A printed warning on a scrolling console is not a gate, so both scripts exited 0 with unmarked assets sitting on disk ready to commit. They now raise, with the reason and the fix; OMNIVOICE_DEMO_ALLOW_UNMARKED=1 stays for a local listen. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * ci: stop a flaky dependency fetch from failing green runs en-core-web-sm resolves to a direct GitHub release URL, and github.com intermittently answers `http2 error: refused stream before processing any application logic`. uv's own three retries all land within the same few seconds and fail together, so the whole job dies on a dependency that has nothing to do with the change under test — it cost #1518 and #1517 an otherwise-green run tonight. Two changes: back off between whole `uv sync` attempts, which is what actually clears it, and pass --no-sync to the pytest steps. `uv run` re-resolves the environment before running, so every test step was a fresh chance to hit the same fetch even though the install step had already synced — that is exactly how #1518 failed, in the isolated backend/tests step, with all 5467 tests already passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * ci: one retry seam for every uv sync, not just the job that failed last en-core-web-sm resolves to a direct GitHub *release* URL rather than a package index, and github.com intermittently answers `http2 error: refused stream before processing any application logic`. uv's own retries all land inside the same ~10 seconds and fail together, so a job dies on a dependency unrelated to the change under test. Tonight that cost four otherwise-green runs across #1515, #1517 and #1518 — and the first fix only covered the Tests job, so the next failure simply moved to Smoke (Linux), which syncs separately. The fetch is per-job, so the fix has to be per-job: scripts/uv-sync-retry.sh backs off between whole attempts (15s, 45s, 90s) and every workflow that syncs now goes through it — ci.yml (tests + the platform matrix), release.yml, security.yml, evals.yml. It still fails loudly after four attempts, so a genuinely broken lockfile is not disguised as a flake. The Tests job also lacked the UV_HTTP_TIMEOUT / UV_HTTP_RETRIES the smoke matrix has always set, which is part of why it was the one that kept dying; it has them now. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(ci): pin the Intel-Mac contract by intent, not by command spelling test_ci_verifies_intel_mac_as_the_documented_remote_only_host asserted the literal line `run: uv sync --extra pockettts`, so routing every sync through scripts/uv-sync-retry.sh read as a broken Intel-Mac contract. The contract it exists to protect is that the pockettts extra installs ONLY on backend_supported legs — which the regex now pins, while leaving how the sync is invoked free to change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * ci: keep every uv run out of the resolver, and bound the retry budget CodeRabbit, #1517: - `uv run` re-resolves before running, so the smoke suite, the worker-artifact tests, the release test run and the eval run were each a fresh chance to hit the flaky direct-URL fetch outside the retry loop. All of them pass --no-sync now; the environment is already synced by the step that owns the retries. security.yml's `uv run --with pip-audit` is deliberately left alone — it layers an ephemeral package rather than running the project's own tests. - The retry count multiplied uv's own budget (UV_HTTP_RETRIES=5 with a 120 s timeout on the smoke matrix). Three attempts and 60 s of total backoff outlast the refusals actually observed while staying well inside the jobs' timeout-minutes. - The Intel-Mac contract test pinned the smoke command literally too, so --no-sync tripped it exactly like the sync line did. Same fix: assert the contract (smoke runs only on backend_supported legs), not its spelling. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
133 lines
5.1 KiB
Python
Executable File
133 lines
5.1 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
"""Render the dubbing demo's five audio tracks with the VoiceStudio engine.
|
|
|
|
`scripts/build_dub_demo.sh` builds the videos, subtitles and manifest, but it
|
|
got its audio from macOS `say` — so the demo could only be built on a Mac, and
|
|
on every other platform the Dub workspace's demo player pointed at files that
|
|
were never generated. The engine runs wherever the app does, which makes it the
|
|
portable answer, and it has the side benefit of the demo being rendered by the
|
|
thing it is demonstrating.
|
|
|
|
Writes `source.src.wav` + `dubbed_<code>.src.wav` next to where the videos will
|
|
be built; `build_dub_demo.sh` picks those up automatically and falls back to
|
|
`say` when they are absent.
|
|
|
|
Prerequisites are the same as scripts/render_demos_omnivoice.py: the project
|
|
venv and cached model weights.
|
|
|
|
Usage:
|
|
python3 scripts/render_dub_demo_audio.py [--skip-existing]
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
import json
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parent.parent
|
|
BACKEND_DIR = REPO_ROOT / "backend"
|
|
# Must match OUT_DIR in build_dub_demo.sh, which must in turn sit under the
|
|
# directory main.py mounts at /demo_audio (backend/assets/samples).
|
|
OUT_DIR = BACKEND_DIR / "assets" / "samples" / "demo" / "dubbing"
|
|
SCRIPTS_JSON = REPO_ROOT / "scripts" / "dub_demo_scripts.json"
|
|
|
|
sys.path.insert(0, str(BACKEND_DIR))
|
|
sys.path.insert(0, str(REPO_ROOT / "scripts"))
|
|
|
|
from render_demos_omnivoice import watermark_file # noqa: E402 — needs sys.path above
|
|
|
|
# The videos are built at 44.1 kHz; rendering straight to it saves the shell
|
|
# script a resample step and keeps every track at one rate.
|
|
VIDEO_SAMPLE_RATE = 44100
|
|
|
|
|
|
def _render(model, text: str, language: str, instruct: str, out: Path, sample_rate: int) -> None:
|
|
"""Synthesize one track and write it at the video pipeline's sample rate."""
|
|
import torch
|
|
import torchaudio
|
|
|
|
audios = model.generate(text=text, instruct=instruct, language=language, num_step=32)
|
|
audio = audios[0]
|
|
if audio.dim() == 1:
|
|
audio = audio.unsqueeze(0)
|
|
if audio.shape[0] > 1:
|
|
audio = audio.mean(dim=0, keepdim=True)
|
|
peak = audio.abs().max().item()
|
|
if peak > 0:
|
|
audio = audio / peak * 0.97
|
|
out.parent.mkdir(parents=True, exist_ok=True)
|
|
audio = audio.to(torch.float32).cpu()
|
|
if sample_rate != VIDEO_SAMPLE_RATE:
|
|
audio = torchaudio.functional.resample(audio, sample_rate, VIDEO_SAMPLE_RATE)
|
|
torchaudio.save(
|
|
str(out), audio, VIDEO_SAMPLE_RATE, encoding="PCM_S", bits_per_sample=16
|
|
)
|
|
# Level-match the tracks: a dub demo where switching language also changes
|
|
# the volume reads as a bug in the dubbing, not in the demo assets. See
|
|
# render_demos_omnivoice.py for why the output rate has to be pinned.
|
|
tmp = out.with_suffix(".norm.wav")
|
|
result = subprocess.run(
|
|
[
|
|
"ffmpeg", "-y", "-loglevel", "error", "-i", str(out),
|
|
"-af", "loudnorm=I=-18:TP=-1.5:LRA=11",
|
|
"-ar", str(VIDEO_SAMPLE_RATE), "-ac", "1",
|
|
"-c:a", "pcm_s16le", str(tmp),
|
|
],
|
|
capture_output=True, text=True,
|
|
)
|
|
if result.returncode == 0 and tmp.exists() and tmp.stat().st_size:
|
|
tmp.replace(out)
|
|
else:
|
|
tmp.unlink(missing_ok=True)
|
|
print(f" ! loudnorm skipped for {out.name}: {result.stderr.strip()[:100]}")
|
|
# These tracks are muxed into a video that ships in the app, so they carry
|
|
# the same provenance mark as any other synthetic audio the app produces
|
|
# (#1169). Last step, after loudnorm — see watermark_file.
|
|
watermark_file(out, VIDEO_SAMPLE_RATE, context=f"demo:dub:{out.stem}")
|
|
|
|
|
|
def main() -> None:
|
|
parser = argparse.ArgumentParser(description=__doc__)
|
|
parser.add_argument(
|
|
"--skip-existing", action="store_true",
|
|
help="Don't re-render tracks that already exist on disk.",
|
|
)
|
|
args = parser.parse_args()
|
|
|
|
spec = json.loads(SCRIPTS_JSON.read_text(encoding="utf-8"))
|
|
instruct = spec["voice_instruct"]
|
|
tracks = [("source", spec["source"])] + [
|
|
(f"dubbed_{entry['code']}", entry) for entry in spec["dubbed"]
|
|
]
|
|
|
|
print("Loading VoiceStudio engine (this can take 30-60 s on first run)…")
|
|
try:
|
|
import asyncio
|
|
|
|
from services.model_manager import get_model
|
|
|
|
model = asyncio.run(get_model())
|
|
except Exception as exc: # noqa: BLE001 - the message is the whole point
|
|
print(f"\nERROR: Could not load VoiceStudio engine: {exc}")
|
|
print("Run `uv sync` first; weights download on first synthesis (~5 GB).")
|
|
sys.exit(1)
|
|
sample_rate = getattr(model, "sampling_rate", 24000)
|
|
print("Engine loaded.\n")
|
|
|
|
for stem, entry in tracks:
|
|
out = OUT_DIR / f"{stem}.src.wav"
|
|
if args.skip_existing and out.exists():
|
|
print(f" · skip (exists): {out.name}")
|
|
continue
|
|
_render(model, entry["script"], entry["language"], instruct, out, sample_rate)
|
|
print(f" ✓ {out.name} ({entry['label']})")
|
|
|
|
print("\nDone. Now run scripts/build_dub_demo.sh to build the videos.")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|