Files
VoiceStudio/docs
debpalashandClaude Opus 4.8 d800f77e26 fix(rocm): #1228 review — a remap is only a fix if the build ships the target
Two P1s, both correct:

- Being IN the override map was treated as proof of compatibility. If the
  wheel ships neither the native arch nor the remap target, setting
  HSA_OVERRIDE_GFX_VERSION only changes WHICH kernel is missing — gfx1151 with
  a gfx1030-only build was routed to the GPU and would fail at launch. Both
  arch_unsupported() and _configure_rocm_if_needed() now require the target to
  be present, and fall back to CPU otherwise.

- An EMPTY arch list means the build's metadata is unavailable, not that the
  GPU is unsupported. The remap branch read that unknown state as a confirmed
  mismatch and would push a natively-supported gfx1151 onto foreign gfx1100
  kernels. Now fails open and changes nothing, matching the fail-open contract
  the rest of the probe follows.

ROCM_GFX_OVERRIDES values are now the target gfx NAME rather than the HSA
version string, so the "is the target present?" check is a direct membership
test; hsa_override_for() derives the env-var form, covered by a test that
every entry in the map converts cleanly.

Also: CHANGELOG entries shortened with refs last, and the MD028 blank line
between the two docker.md blockquotes (CodeRabbit).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-23 03:33:26 +05:30
..