mergetestandClaude Fable 5
a601db8448
Two Windows-only backend crash classes, one boundary (process spawn/stdio): forrtl: error (200) (#1153 and the crash markers in #1155/#1152): MKL's Intel Fortran runtime installs a console CTRL handler that aborts the whole backend (exit 2 / 0xC000013A) when a console CLOSE/LOGOFF event reaches it. The backend was spawned with no console isolation, so OS console events could reach it mid-session. Now: - the desktop shell spawns the backend with CREATE_NO_WINDOW | CREATE_NEW_PROCESS_GROUP (no console → no console events, stdio is piped anyway) and sets FOR_DISABLE_CONSOLE_CTRL_HANDLER=1; - backend/main.py setdefaults the same var before torch/numpy can load MKL, covering scripts/run.sh and bare uvicorn launches too. 'charmap' codec can't encode (#1155): kittentts print()s the user's text on every generate; on Windows the child's stdout is cp1252, so Vietnamese text raised UnicodeEncodeError and surfaced as a bogus '400 Bad Request'. The process-wide SafeFileWrapper only swallowed OSError (its EPIPE job). Now: - stdio is reconfigured to UTF-8 (errors=backslashreplace) at startup; - SafeFileWrapper also swallows UnicodeError — logs are best-effort, synthesis is not; - the shell sets PYTHONUTF8=1 for the child (Windows→parity with macOS/Linux; process env wins for power users); - the crash-log append opens with encoding=utf-8 so tracebacks carrying user text can't re-trip the same codec. Regression tests: tests/test_windows_stdio_guards.py (cp1252 stream write must not raise; main must set the Fortran guard + UTF-8 stdio). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
58 lines
2.5 KiB
Python
58 lines
2.5 KiB
Python
"""#1155 / #1153 — Windows stdio + console guards.
|
|
|
|
Two crash classes from the wild, one boundary:
|
|
|
|
* #1155: kittentts `print()`s the user's text; on Windows the backend's
|
|
stdout defaults to cp1252, so Vietnamese/CJK/etc. raised
|
|
UnicodeEncodeError — surfaced to the user as a bogus
|
|
`400 Bad Request: 'charmap' codec can't encode character…`. The
|
|
process-wide SafeFileWrapper only swallowed OSError (its EPIPE job), so
|
|
the encode error sailed through. Guard both layers: stdio is reconfigured
|
|
to UTF-8 at startup, and the wrapper also swallows UnicodeError (logs are
|
|
best-effort; synthesis is not).
|
|
|
|
* #1153-class: the Intel Fortran runtime (MKL, under numpy/scipy) installs
|
|
a console CTRL handler that aborts the whole backend with
|
|
`forrtl: error (200): program aborting due to window-CLOSE event` when a
|
|
console CLOSE event reaches the process. FOR_DISABLE_CONSOLE_CTRL_HANDLER=1
|
|
disables that handler; main.py must set it before MKL can load. (The
|
|
desktop shell also sets it — plus CREATE_NO_WINDOW — at spawn; this is
|
|
the guard for `scripts/run.sh` / `python -m uvicorn` launches.)
|
|
"""
|
|
import io
|
|
import os
|
|
import sys
|
|
|
|
os.environ.setdefault("OMNIVOICE_MODEL", "test")
|
|
os.environ.setdefault("OMNIVOICE_DISABLE_FILE_LOG", "1")
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "backend"))
|
|
|
|
VIETNAMESE = "Generating audio for text: xin chào, bạn khỏe không ả" # noqa: RUF001
|
|
|
|
|
|
def test_safe_file_wrapper_swallows_unicode_encode_errors():
|
|
from utils.hf_progress import SafeFileWrapper
|
|
|
|
cp1252 = io.TextIOWrapper(io.BytesIO(), encoding="cp1252")
|
|
wrapped = SafeFileWrapper(cp1252)
|
|
# The exact #1155 shape: user text with U+1EA3 hitting a charmap stream.
|
|
wrapped.write(VIETNAMESE) # must not raise
|
|
wrapped.flush()
|
|
|
|
|
|
def test_main_sets_fortran_console_guard_and_utf8_stdio():
|
|
import main # noqa: F401 (import-time side effects are the contract)
|
|
|
|
# forrtl error (200) guard — read by the Intel Fortran RTL at DLL init,
|
|
# so it must be in the environment before torch/numpy import MKL.
|
|
assert os.environ.get("FOR_DISABLE_CONSOLE_CTRL_HANDLER") == "1"
|
|
|
|
# The stream under the EPIPE wrapper must be UTF-8 so no library print
|
|
# of user text can ever hit a charmap codec (kittentts does exactly
|
|
# that on every generate call).
|
|
for stream in (sys.stdout, sys.stderr):
|
|
fp = getattr(stream, "fp", stream)
|
|
enc = (getattr(fp, "encoding", None) or "utf-8").lower().replace("-", "")
|
|
assert enc == "utf8", f"stdio still on {enc}"
|