Palash DebnathandClaude Opus 4.8
ab492c0e8e
* fix(docker): fix stale :latest tag and add push-to-main trigger (closes #251, addresses #249) Two bugs caused the Docker image to be stale (showing v0.2.7 inside a :latest/:0.3.x-tagged image): 1. **`:latest` was never set on tag pushes.** The metadata-action rule `type=raw,value=latest,enable={{is_default_branch}}` evaluates `is_default_branch` as false on tag-triggered runs (which run in a detached-HEAD context, not on the default branch). The tag rule was replaced with `enable=${{ github.ref_type == 'tag' }}` so `:latest` is updated on every `v*` tag push. 2. **No trigger for main-branch pushes.** There was no way to keep an up-to-date `:main` edge image between releases. Added `push: branches: [main]` which produces a `:main` rolling tag. Also added a note in the workflow and docs clarifying that the update-channel toggle (Settings → About) is a Tauri desktop feature and does not apply to the Docker image (headless web-server build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(docker): gate mutable tags to push events + guard :latest against prereleases (PR #252 review) - semver / :latest / :main now require github.event_name == 'push' so a manual workflow_dispatch only ever emits a throwaway :sha- tag (no mutable-tag rollback) - :latest excludes prerelease tags (ref contains '-') so an rc/beta can't clobber it - header + tag-strategy comments corrected (:sha- emits on every trigger) Addresses greptile + coderabbit review on #252. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
94 lines
3.6 KiB
YAML
94 lines
3.6 KiB
YAML
# Publish Docker images to GitHub Container Registry (GHCR).
|
|
#
|
|
# Triggers:
|
|
# - push of a tag matching `v*` (e.g. `v0.3.0`) → :0.3.0, :0.3, :latest, :sha-
|
|
# - push to main branch → :main, :sha- (rolling "edge" build)
|
|
# - workflow_dispatch → :sha- only (ad-hoc test build)
|
|
#
|
|
# Tag ↔ image mapping
|
|
# :latest — always the most recent versioned release (set on every v* tag push)
|
|
# :0.3.0 — exact version from the git tag
|
|
# :0.3 — major.minor floating tag (updated on every patch within the minor)
|
|
# :main — latest commit on main; may be ahead of the last tagged release
|
|
# :sha-xxxx — specific commit SHA; produced by workflow_dispatch
|
|
#
|
|
# Images land at: ghcr.io/debpalash/omnivoice-studio
|
|
#
|
|
# NOTE: the Docker image is the headless web-server build of OmniVoice (FastAPI
|
|
# backend + pre-built React frontend served over HTTP). The Tauri desktop
|
|
# auto-updater and its update-channel toggle are desktop-only features; they do
|
|
# NOT apply to the Docker image.
|
|
|
|
name: Docker (GHCR)
|
|
|
|
on:
|
|
push:
|
|
tags: ['v*']
|
|
branches: [main]
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
packages: write
|
|
|
|
env:
|
|
REGISTRY: ghcr.io
|
|
IMAGE_NAME: ${{ github.repository }}
|
|
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
|
|
|
|
jobs:
|
|
build-and-push:
|
|
runs-on: ubuntu-22.04
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
# QEMU enables cross-platform builds (arm64 on x64 runner).
|
|
# Skipped for now — only building linux/amd64.
|
|
# - uses: docker/setup-qemu-action@v3
|
|
|
|
- name: Set up Docker Buildx
|
|
uses: docker/setup-buildx-action@v3
|
|
|
|
- name: Log in to GHCR
|
|
uses: docker/login-action@v3
|
|
with:
|
|
registry: ${{ env.REGISTRY }}
|
|
username: ${{ github.actor }}
|
|
password: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
# Tag strategy (`:sha-<short>` is emitted on every trigger):
|
|
# v0.3.0 tag push → :0.3.0, :0.3, :latest, :sha-
|
|
# main branch push → :main, :sha-
|
|
# workflow_dispatch → :sha- only
|
|
#
|
|
# Fix for stale :latest (issues #249, #251):
|
|
# The previous rule used `enable={{is_default_branch}}`, which evaluates
|
|
# to false on tag pushes (detached HEAD) — so :latest was never updated
|
|
# when a release tag was pushed. The version / :latest / :main rules are
|
|
# gated on `github.event_name == 'push'` so a manual workflow_dispatch can
|
|
# only ever produce a throwaway `:sha-` tag (never republish a mutable
|
|
# tag), and :latest additionally excludes prerelease tags (those contain a
|
|
# `-`, e.g. v1.0.0-rc.1) so a prerelease can't clobber :latest.
|
|
- name: Extract metadata (tags, labels)
|
|
id: meta
|
|
uses: docker/metadata-action@v5
|
|
with:
|
|
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
|
|
tags: |
|
|
type=semver,pattern={{version}},enable=${{ github.event_name == 'push' }}
|
|
type=semver,pattern={{major}}.{{minor}},enable=${{ github.event_name == 'push' }}
|
|
type=raw,value=latest,enable=${{ github.event_name == 'push' && github.ref_type == 'tag' && !contains(github.ref, '-') }}
|
|
type=raw,value=main,enable=${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
|
|
type=sha,prefix=sha-,format=short
|
|
|
|
- name: Build and push
|
|
uses: docker/build-push-action@v6
|
|
with:
|
|
context: .
|
|
file: deploy/Dockerfile
|
|
push: true
|
|
tags: ${{ steps.meta.outputs.tags }}
|
|
labels: ${{ steps.meta.outputs.labels }}
|
|
cache-from: type=gha
|
|
cache-to: type=gha,mode=max
|