From b60794b60f59d038381255faa7977059e51eecb1 Mon Sep 17 00:00:00 2001 From: Xuan Son Nguyen Date: Thu, 23 Jul 2026 18:51:19 +0200 Subject: [PATCH] nits --- skills/code-review/SKILL.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/skills/code-review/SKILL.md b/skills/code-review/SKILL.md index c7b7e2bd9d..84075fea32 100644 --- a/skills/code-review/SKILL.md +++ b/skills/code-review/SKILL.md @@ -90,8 +90,8 @@ See the `add-new-model` skill and `docs/development/HOWTO-add-model.md` for the - New op or operator change needs corresponding `test-backend-ops` cases, and (per `CONTRIBUTING.md`) consistency across at least two backends. - New kernels are expected to come with concrete perf data (throughput across realistic tensor shapes), not just correctness. - Don't have a backend mutate the cgraph as a shortcut - that's an unresolved architectural question, not something to slip in. -- Expect this to need two maintainer approvals; that's normal for `ggml/` changes, not a sign something is wrong. -- For CUDA: Avoid excessively templating kernels, only add this where it shows visible performance gain. +- Expect this to need two maintainer approvals; that's normal for `ggml/` changes, not a sign something is wrong. +- For CUDA: Avoid excessively templating kernels, only add this where it shows visible performance gain. ## Public API (`include/llama.h`)