mirror of
https://github.com/ollama/ollama.git
synced 2026-09-21 05:28:00 -05:00
fix(docs): correct typos found during code review (#17579)
* fix(docs): correct typos found during code review Non-functional changes only: - Fixed minor spelling mistakes in comments - Corrected typos in user-facing strings - No variables, logic, or functional code was modified. Signed-off-by: Marcel Petrick <mail@marcelpetrick.it> * fix additional typos and shell-unsafe example in docs --------- Co-authored-by: Patrick Devine <patrick@ollama.com>
This commit is contained in:
co-authored by
Patrick Devine
parent
f96e7aa051
commit
e37a00a8fa
@@ -273,7 +273,7 @@ function ToolRoleContent({
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
return (
|
return (
|
||||||
// collapsable tool result with raw json
|
// collapsible tool result with raw json
|
||||||
<div className="space-y-2">
|
<div className="space-y-2">
|
||||||
{content && !rawToolResult && (
|
{content && !rawToolResult && (
|
||||||
<pre className="text-xs whitespace-pre-wrap overflow-x-auto bg-neutral-100 dark:bg-neutral-800 text-neutral-800 dark:text-neutral-200 p-2 rounded-md max-h-40">
|
<pre className="text-xs whitespace-pre-wrap overflow-x-auto bg-neutral-100 dark:bg-neutral-800 text-neutral-800 dark:text-neutral-200 p-2 rounded-md max-h-40">
|
||||||
|
|||||||
@@ -149,7 +149,7 @@ func DoUpgrade(interactive bool) error {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Get ready to try to unwind a partial upgade failure during unzip
|
// Get ready to try to unwind a partial upgrade failure during unzip
|
||||||
// If something goes wrong, we attempt to put the old version back.
|
// If something goes wrong, we attempt to put the old version back.
|
||||||
anyFailures := false
|
anyFailures := false
|
||||||
defer func() {
|
defer func() {
|
||||||
|
|||||||
@@ -345,7 +345,7 @@ WEBVIEW_API void webview_unbind(webview_t w, const char *name);
|
|||||||
* @param seq The sequence number of the binding call. Pass along the value
|
* @param seq The sequence number of the binding call. Pass along the value
|
||||||
* received in the binding handler (see webview_bind()).
|
* received in the binding handler (see webview_bind()).
|
||||||
* @param status A status of zero tells the JS side that the binding call was
|
* @param status A status of zero tells the JS side that the binding call was
|
||||||
* succesful; any other value indicates an error.
|
* successful; any other value indicates an error.
|
||||||
* @param result The result of the binding call to be returned to the JS side.
|
* @param result The result of the binding call to be returned to the JS side.
|
||||||
* This must either be a valid JSON value or an empty string for
|
* This must either be a valid JSON value or an empty string for
|
||||||
* the primitive JS value @c undefined.
|
* the primitive JS value @c undefined.
|
||||||
|
|||||||
@@ -104,7 +104,7 @@ func (t *winTray) wndProc(hWnd windows.Handle, message uint32, wParam, lParam ui
|
|||||||
}
|
}
|
||||||
err = t.wcex.unregister()
|
err = t.wcex.unregister()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
slog.Error(fmt.Sprintf("failed to uregister windo %s", err))
|
slog.Error(fmt.Sprintf("failed to unregister window %s", err))
|
||||||
}
|
}
|
||||||
case WM_DESTROY:
|
case WM_DESTROY:
|
||||||
// slog.Debug("XXX WM_DESTROY triggered")
|
// slog.Debug("XXX WM_DESTROY triggered")
|
||||||
|
|||||||
@@ -330,7 +330,7 @@ Examples:
|
|||||||
},
|
},
|
||||||
RunE: func(cmd *cobra.Command, args []string) error {
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
policy := defaultLaunchPolicy(isInteractiveSession(), yesFlag)
|
policy := defaultLaunchPolicy(isInteractiveSession(), yesFlag)
|
||||||
// reset when done to make sure state doens't leak between launches
|
// reset when done to make sure state doesn't leak between launches
|
||||||
restoreConfirmPolicy := withLaunchConfirmPolicy(policy.confirmPolicy())
|
restoreConfirmPolicy := withLaunchConfirmPolicy(policy.confirmPolicy())
|
||||||
defer restoreConfirmPolicy()
|
defer restoreConfirmPolicy()
|
||||||
|
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ Vision models accept images alongside text so the model can describe, classify,
|
|||||||
## Quick start
|
## Quick start
|
||||||
|
|
||||||
```shell
|
```shell
|
||||||
ollama run gemma4 ./image.png whats in this image?
|
ollama run gemma4 ./image.png what is in this image?
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -340,7 +340,7 @@ func TestHarmonyParserStreaming(t *testing.T) {
|
|||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
desc: "message with channel and recipient (receipient before channel)",
|
desc: "message with channel and recipient (recipient before channel)",
|
||||||
steps: []step{
|
steps: []step{
|
||||||
{
|
{
|
||||||
input: "<|start|>assistant to=functions.calc<|channel|>commentary<|message|>",
|
input: "<|start|>assistant to=functions.calc<|channel|>commentary<|message|>",
|
||||||
|
|||||||
@@ -413,7 +413,7 @@ func runAPIShowModel(t *testing.T) {
|
|||||||
}
|
}
|
||||||
// llama3 omits system
|
// llama3 omits system
|
||||||
verifyModelDetails(t, resp.Details)
|
verifyModelDetails(t, resp.Details)
|
||||||
// llama3 ommits messages
|
// llama3 omits messages
|
||||||
if len(resp.ModelInfo) == 0 {
|
if len(resp.ModelInfo) == 0 {
|
||||||
t.Errorf("%s missing model_info: %#v", modelName, resp)
|
t.Errorf("%s missing model_info: %#v", modelName, resp)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -136,7 +136,7 @@ func containsEmoji(s string) bool {
|
|||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|
||||||
// Send multiple generate requests with prior context and ensure the response is coherant and expected
|
// Send multiple generate requests with prior context and ensure the response is coherent and expected
|
||||||
func runParallelGenerateWithHistory(t *testing.T, modelName string) {
|
func runParallelGenerateWithHistory(t *testing.T, modelName string) {
|
||||||
if testModel != "" {
|
if testModel != "" {
|
||||||
// The Generate API's Context field (token array continuation) is not
|
// The Generate API's Context field (token array continuation) is not
|
||||||
@@ -194,7 +194,7 @@ func runParallelGenerateWithHistory(t *testing.T, modelName string) {
|
|||||||
wg.Wait()
|
wg.Wait()
|
||||||
}
|
}
|
||||||
|
|
||||||
// Send generate requests with prior context and ensure the response is coherant and expected
|
// Send generate requests with prior context and ensure the response is coherent and expected
|
||||||
func runGenerateWithHistory(t *testing.T) {
|
func runGenerateWithHistory(t *testing.T) {
|
||||||
if testModel != "" {
|
if testModel != "" {
|
||||||
// The Generate API's Context field (token array continuation) is not
|
// The Generate API's Context field (token array continuation) is not
|
||||||
@@ -234,7 +234,7 @@ func runGenerateWithHistory(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Send multiple chat requests with prior context and ensure the response is coherant and expected
|
// Send multiple chat requests with prior context and ensure the response is coherent and expected
|
||||||
func runParallelChatWithHistory(t *testing.T, modelName string) {
|
func runParallelChatWithHistory(t *testing.T, modelName string) {
|
||||||
req, resp := ChatRequests()
|
req, resp := ChatRequests()
|
||||||
numParallel := 2
|
numParallel := 2
|
||||||
@@ -299,7 +299,7 @@ func prepareParallelHistoryModel(ctx context.Context, t *testing.T, client *api.
|
|||||||
skipIfModelTooLargeForSweepVRAM(ctx, t, client, modelName)
|
skipIfModelTooLargeForSweepVRAM(ctx, t, client, modelName)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Send generate requests with prior context and ensure the response is coherant and expected
|
// Send generate requests with prior context and ensure the response is coherent and expected
|
||||||
func runChatWithHistory(t *testing.T) {
|
func runChatWithHistory(t *testing.T) {
|
||||||
req := api.ChatRequest{
|
req := api.ChatRequest{
|
||||||
Model: smol,
|
Model: smol,
|
||||||
|
|||||||
@@ -161,7 +161,7 @@ func TestQwen3VLNonThinkingParserStreaming(t *testing.T) {
|
|||||||
desc: "partial thinking incomplete",
|
desc: "partial thinking incomplete",
|
||||||
steps: []step{
|
steps: []step{
|
||||||
{
|
{
|
||||||
input: "abc<think>unfinished<", // when something is ambiguious, we dont emit anything
|
input: "abc<think>unfinished<", // when something is ambiguous, we dont emit anything
|
||||||
wantEvents: []qwenEvent{qwenEventContent{content: "abc<think>unfinished"}},
|
wantEvents: []qwenEvent{qwenEventContent{content: "abc<think>unfinished"}},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -170,7 +170,7 @@ func TestQwen3VLNonThinkingParserStreaming(t *testing.T) {
|
|||||||
desc: "test with split tool and content",
|
desc: "test with split tool and content",
|
||||||
steps: []step{
|
steps: []step{
|
||||||
{
|
{
|
||||||
input: "abc<tool_call>unfinished</", // when something is ambiguious, we dont emit anything
|
input: "abc<tool_call>unfinished</", // when something is ambiguous, we dont emit anything
|
||||||
wantEvents: []qwenEvent{
|
wantEvents: []qwenEvent{
|
||||||
qwenEventContent{content: "abc"},
|
qwenEventContent{content: "abc"},
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -149,7 +149,7 @@ func TestQwen3VLThinkingParserStreaming(t *testing.T) {
|
|||||||
desc: "partial thinking incomplete",
|
desc: "partial thinking incomplete",
|
||||||
steps: []step{
|
steps: []step{
|
||||||
{
|
{
|
||||||
input: "abc<think>unfinished</think", // when something is ambiguious, we dont emit anything
|
input: "abc<think>unfinished</think", // when something is ambiguous, we dont emit anything
|
||||||
wantEvents: []qwenEvent{qwenEventThinkingContent{content: "abc<think>unfinished"}},
|
wantEvents: []qwenEvent{qwenEventThinkingContent{content: "abc<think>unfinished"}},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -158,7 +158,7 @@ func TestQwen3VLThinkingParserStreaming(t *testing.T) {
|
|||||||
desc: "test with split thinking and content",
|
desc: "test with split thinking and content",
|
||||||
steps: []step{
|
steps: []step{
|
||||||
{
|
{
|
||||||
input: "abc<think>unfinished</th", // when something is ambiguious, we dont emit anything
|
input: "abc<think>unfinished</th", // when something is ambiguous, we dont emit anything
|
||||||
wantEvents: []qwenEvent{qwenEventThinkingContent{content: "abc<think>unfinished"}},
|
wantEvents: []qwenEvent{qwenEventThinkingContent{content: "abc<think>unfinished"}},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
|||||||
+1
-1
@@ -2,7 +2,7 @@
|
|||||||
|
|
||||||
> Note: this is a work in progress
|
> Note: this is a work in progress
|
||||||
|
|
||||||
A minimial runner for loading a model and running inference via a http web server.
|
A minimal runner for loading a model and running inference via a http web server.
|
||||||
|
|
||||||
```shell
|
```shell
|
||||||
./runner -model <model binary>
|
./runner -model <model binary>
|
||||||
|
|||||||
@@ -59,7 +59,7 @@ func TestThinkingStreaming(t *testing.T) {
|
|||||||
wantStateAfter: thinkingState_ThinkingDone,
|
wantStateAfter: thinkingState_ThinkingDone,
|
||||||
},
|
},
|
||||||
// regression test for a bug where we were transitioning directly to
|
// regression test for a bug where we were transitioning directly to
|
||||||
// ThinkingDone without clearing the buffer. This would cuase the first
|
// ThinkingDone without clearing the buffer. This would cause the first
|
||||||
// step to be outputted twice
|
// step to be outputted twice
|
||||||
{
|
{
|
||||||
input: "def",
|
input: "def",
|
||||||
|
|||||||
@@ -379,7 +379,7 @@ func TestCausalConv1DSegmentEquivalenceBatched(t *testing.T) {
|
|||||||
// Each row's boundary i (offset i+1) must equal a B=1 single-shot conv over
|
// Each row's boundary i (offset i+1) must equal a B=1 single-shot conv over
|
||||||
// that row's real prefix: row 0 advances the full length, row 1 freezes once
|
// that row's real prefix: row 0 advances the full length, row 1 freezes once
|
||||||
// it reaches its real length 3. Per-row B=1 references avoid the ambiguity of
|
// it reaches its real length 3. Per-row B=1 references avoid the ambiguity of
|
||||||
// re-declaring a ragged length over a uniform input slice.
|
// redeclaring a ragged length over a uniform input slice.
|
||||||
rowReal := []int32{int32(L), 3}
|
rowReal := []int32{int32(L), 3}
|
||||||
for i := range segStates {
|
for i := range segStates {
|
||||||
for r := range B {
|
for r := range B {
|
||||||
|
|||||||
Reference in New Issue
Block a user