Files
ollama/create/nemotron_h.go
T
Jesse Gross 2e036e7cdf mlx, mlxrunner: move the MLX engine out of x/
The MLX runner is the only Go inference runner left and is no longer
experimental, so its packages leave x/. The bindings become a top-level
mlx package beside the carried patches in mlx/compat, mirroring how
llama/ holds the llama.cpp integration, and the runner becomes mlxrunner
with the architectures nested under the package they implement.
Subpackages move with their parent unless listed.

  x/mlxrunner/mlx            mlx
  x/internal/mlxthread       mlx/mlxthread
  x/internal/mlxthreadtest   mlx/mlxthread/mlxthreadtest
  x/internal/mlxtest         mlx/mlxtest
  x/quant                    mlx/quant
  mlx/compat/*.patch         mlx/compat/mlx-c   (MLX patches go in mlx/compat/mlx)
  x/mlxrunner                mlxrunner
  x/models/nn                mlxrunner/nn
  x/models/<arch>            mlxrunner/model/<arch>
  x/mlxrunner/imports.go     mlxrunner/model/architectures   (new package)
  x/create                   create
  x/safetensors              fs/safetensors
  x/tokenizer                mlxrunner/tokenizer

Every package keeps its name, so the Go changes are the import path
rewrites the moves force, and the CMake, Dockerfile, CI cache keys, drift
check and Darwin payload script follow the new paths. Four edits are not
paths: the runner's blank architecture imports become the package
mlxrunner/model/architectures, so the list to extend for a new model sits
beside the architecture directories; a depguard rule keeps the two test
harnesses out of non-test code, as the x/internal placement used to; the
CI change filter's two entries for the long-deleted x/imagegen/mlx now
name the bindings' CMake project and the carried patches, so a change to
either builds the payload; and the tokenizer parity test reads its
fixtures from its own testdata instead of walking out of x/.

x/server and x/imagegen/manifest stay for the next two commits.
2026-09-16 14:06:08 -07:00

100 lines
3.1 KiB
Go

package create
import (
"encoding/json"
"fmt"
"strings"
)
type nemotronHImportTransform struct {
numLayers int
}
func newNemotronHImportTransform(rawConfig json.RawMessage) (quantizePolicy, error) {
var cfg struct {
NumHiddenLayers int `json:"num_hidden_layers"`
LLMConfig struct {
NumHiddenLayers int `json:"num_hidden_layers"`
} `json:"llm_config"`
}
if err := json.Unmarshal(rawConfig, &cfg); err != nil {
return nil, fmt.Errorf("nemotron_h: parse config.json: %w", err)
}
numLayers := cfg.NumHiddenLayers
if numLayers == 0 {
numLayers = cfg.LLMConfig.NumHiddenLayers
}
return nemotronHImportTransform{numLayers: numLayers}, nil
}
func nemotronHIsUnsupportedModalityTensor(name string) bool {
return strings.HasPrefix(name, "vision_model.") ||
strings.HasPrefix(name, "mlp1.") ||
strings.HasPrefix(name, "sound_encoder.") ||
strings.HasPrefix(name, "sound_projection.")
}
func nemotronHShouldKeepBF16ForDirectNonAffine(name string) bool {
switch {
case strings.HasSuffix(name, ".mixer.gate.weight"):
return true
case strings.HasSuffix(name, ".mixer.conv1d.weight"):
return true
default:
return false
}
}
func nemotronHIsAttentionProjection(name string) bool {
return strings.HasSuffix(name, ".mixer.q_proj.weight") ||
strings.HasSuffix(name, ".mixer.k_proj.weight") ||
strings.HasSuffix(name, ".mixer.v_proj.weight") ||
strings.HasSuffix(name, ".mixer.o_proj.weight")
}
// promoteSensitive reports whether a sensitive tensor takes the 8-bit type.
// Attention always does: few layers carry it, 4-bit attention degrades
// structured output, and promoting all of it is free. Experts keep the
// schedule, where the decode bandwidth saving is real.
func (t nemotronHImportTransform) promoteSensitive(name string) bool {
if nemotronHIsAttentionProjection(name) {
return true
}
layerIdx := layerIndex(name)
return layerIdx < 0 || useMoreBits(layerIdx, t.numLayers)
}
func (t nemotronHImportTransform) quantizationType(name string, shape []int32, quantize string) string {
if nemotronHIsUnsupportedModalityTensor(name) || nemotronHShouldKeepBF16ForDirectNonAffine(name) {
return ""
}
quantNorm := normalizeQuantType(quantize)
// lm_head and token embeddings are sensitive but high-bandwidth;
// promote them to 8-bit in the requested quant family when the
// shape fits, otherwise keep them at source precision.
if strings.HasSuffix(name, "embeddings.weight") || strings.HasSuffix(name, "lm_head.weight") {
return promoteEmbedding(shape, quantNorm)
}
if quantNorm == "nvfp4" || quantNorm == "mxfp4" {
isSensitive := nemotronHIsAttentionProjection(name) ||
strings.HasSuffix(name, ".mixer.out_proj.weight") ||
strings.HasSuffix(name, ".mixer.down_proj.weight") ||
strings.Contains(name, ".mixer.experts.") && strings.HasSuffix(name, ".down_proj.weight") ||
strings.HasSuffix(name, ".mixer.shared_experts.down_proj.weight")
if isSensitive {
if isAligned(shape, "mxfp8") && t.promoteSensitive(name) {
return "mxfp8"
}
if isAligned(shape, quantNorm) {
return quantNorm
}
return ""
}
}
return GetTensorQuantization(name, shape, quantize)
}