Files
ollama/mlx/compat/mlx-c/0001-mlx-c-qmm-global-scale.patch
T
Jesse Gross 2e036e7cdf mlx, mlxrunner: move the MLX engine out of x/
The MLX runner is the only Go inference runner left and is no longer
experimental, so its packages leave x/. The bindings become a top-level
mlx package beside the carried patches in mlx/compat, mirroring how
llama/ holds the llama.cpp integration, and the runner becomes mlxrunner
with the architectures nested under the package they implement.
Subpackages move with their parent unless listed.

  x/mlxrunner/mlx            mlx
  x/internal/mlxthread       mlx/mlxthread
  x/internal/mlxthreadtest   mlx/mlxthread/mlxthreadtest
  x/internal/mlxtest         mlx/mlxtest
  x/quant                    mlx/quant
  mlx/compat/*.patch         mlx/compat/mlx-c   (MLX patches go in mlx/compat/mlx)
  x/mlxrunner                mlxrunner
  x/models/nn                mlxrunner/nn
  x/models/<arch>            mlxrunner/model/<arch>
  x/mlxrunner/imports.go     mlxrunner/model/architectures   (new package)
  x/create                   create
  x/safetensors              fs/safetensors
  x/tokenizer                mlxrunner/tokenizer

Every package keeps its name, so the Go changes are the import path
rewrites the moves force, and the CMake, Dockerfile, CI cache keys, drift
check and Darwin payload script follow the new paths. Four edits are not
paths: the runner's blank architecture imports become the package
mlxrunner/model/architectures, so the list to extend for a new model sits
beside the architecture directories; a depguard rule keeps the two test
harnesses out of non-test code, as the x/internal placement used to; the
CI change filter's two entries for the long-deleted x/imagegen/mlx now
name the bindings' CMake project and the carried patches, so a change to
either builds the payload; and the tokenizer parity test reads its
fixtures from its own testdata instead of walking out of x/.

x/server and x/imagegen/manifest stay for the next two commits.
2026-09-16 14:06:08 -07:00

34 lines
1.1 KiB
Diff

diff --git a/mlx/c/ops.cpp b/mlx/c/ops.cpp
index bf565d1..435706a 100644
--- a/mlx/c/ops.cpp
+++ b/mlx/c/ops.cpp
@@ -1687,6 +1687,7 @@ extern "C" int mlx_gather_qmm(
mlx_optional_int group_size,
mlx_optional_int bits,
const char* mode,
+ const mlx_array global_scale /* may be null */,
bool sorted_indices,
const mlx_stream s) {
try {
@@ -1708,6 +1709,8 @@ extern "C" int mlx_gather_qmm(
(bits.has_value ? std::make_optional<int>(bits.value)
: std::nullopt),
std::string(mode),
+ (global_scale.ctx ? std::make_optional(mlx_array_get_(global_scale))
+ : std::nullopt),
sorted_indices,
mlx_stream_get_(s)));
} catch (std::exception& e) {
diff --git a/mlx/c/ops.h b/mlx/c/ops.h
index 7417785..6dfbf9e 100644
--- a/mlx/c/ops.h
+++ b/mlx/c/ops.h
@@ -548,6 +548,7 @@ int mlx_gather_qmm(
mlx_optional_int group_size,
mlx_optional_int bits,
const char* mode,
+ const mlx_array global_scale /* may be null */,
bool sorted_indices,
const mlx_stream s);
int mlx_gather_qqmm(