Files
ollama/x/mlxrunner/prefix_cache.go
T
Jesse Gross b859a94509 mlxrunner: keep the reused head of a cached edge safe from eviction
When a request resumes partway through a cached edge, the node holding
that edge was dropped from the active path, because the path has to end
at the live offset for close and the prefill captures to extend the trie
from its last node. Off the path, the node was an ordinary leaf with a
stale last-used time, so eviction removed it first.

The captures taken during that request start at the resume offset, but
attach rebuilds the missing node from the path's last node, so the new
node's edge begins earlier than its KV snapshot. A later request
resuming there was refused by the KV cache and re-prefilled from
scratch. If eviction first merged the node into its parent, the two
snapshots were concatenated as if adjacent, and the restore reported a
hit while the buffer held tokens from other positions.

Split the node at the live offset instead. The head stays on the path
and gets the last-used update. Only the unused tail can be evicted, and
losing it costs nothing. The split only happens when every layer can
rewind into the edge, so it never involves a recurrent layer, and the
head gets the same KV-only snapshots a close-time split already
produces. When the request follows the edge, compaction merges the
halves back.
2026-09-10 15:20:11 -07:00

751 lines
22 KiB
Go

// prefix_cache.go manages cache state shared across conversations using a
// compressed prefix trie. Each trie node stores a token sequence (edge) and
// optional per-layer snapshots that can be paged in/out of the live MLX cache
// arrays.
//
// Invariants:
// - Only one path through the trie is "active" (backed by live MLX arrays)
// at a time. Switching paths pages in the new path from its snapshots.
// - Sliceable (KV) layers: every node holds a snapshot covering exactly its
// edge, so the layer's history is complete along any path from the root.
// - Whole-state (recurrent, rotating) layers: what a node holds is the
// state at its end offset. A node may hold none.
// - Whole-state is captured only while the live caches sit at that offset
// (prefill captures, the page-out at close) and is never rebuilt later. A
// node split out of an existing edge afterward therefore holds none.
// - A request resumes at the deepest node at or below its match that holds
// whole-state. begin schedules a capture at the match, so any node a
// request resumes at holds whole-state afterward.
// - All cache layers must stay at the same token offset.
// - Draft caches are settled whenever the trie captures, pages out, or
// rewinds: no entry is still waiting on the next token.
// - A non-causal media item's tokens are evaluated in one batch: no node
// boundary or resume point lies strictly inside them.
// - Sibling edges must not share a common token prefix (compressed trie
// invariant).
// - begin() always re-evaluates at least one token so the pipeline can seed
// generation, even on a full prefix match.
package mlxrunner
import (
"cmp"
"fmt"
"log/slog"
"slices"
"time"
"github.com/ollama/ollama/logutil"
"github.com/ollama/ollama/x/mlxrunner/cache"
"github.com/ollama/ollama/x/mlxrunner/mlx"
)
const maxPagedOutBytes int64 = 8 << 30 // 8 GiB eviction threshold for paged-out snapshot memory
type prefixCache struct {
root *trieNode // root of the prefix trie
activePath []*trieNode // current root→leaf path with live MLX arrays
caches []cache.Cache
pagedOutBytes int64 // total bytes in paged-out snapshots across the trie
// draftLookahead is how far the draft caches' entries reference past
// their own slot; trie keys pack each token with its look-ahead (see key).
draftLookahead int
}
// pendingSnapshot is a snapshot scheduled to be taken during prefill.
type pendingSnapshot struct {
offset int
user bool
}
// cacheSession manages caches for a single pipeline run.
// Callers should append generated tokens to outputs and
// defer close to save the cache state.
type cacheSession struct {
cache *prefixCache
inputs []int32
effInputs []uint32 // inputs' key alphabet, media folds applied
items []mediaItem
outputs []int32
caches []cache.Cache
remaining []int32
// pendingSnapshots lists offsets where snapshots should be captured
// during prefill, sorted by offset. Entries are scheduled on the caches
// before prefill and drained when the captures are attached.
pendingSnapshots []pendingSnapshot
}
// newPrefixCache manages the given cache slots for the model's life.
func newPrefixCache(caches []cache.Cache) *prefixCache {
return &prefixCache{caches: caches}
}
func (c *prefixCache) ensureRoot() {
if c.root == nil {
c.root = &trieNode{
lastUsed: time.Now(),
}
c.activePath = []*trieNode{c.root}
}
}
// begin prepares caches for a new request. It finds the nearest
// matching cache or creates new caches if none match.
func (c *prefixCache) begin(inputs []int32, items []mediaItem) *cacheSession {
c.ensureRoot()
effInputs := effectiveKeyTokens(inputs, items)
keys := c.key(effInputs)
matchPath, matched := findBestMatch(c.root, keys)
originalMatched := matched
// Always keep at least one token to re-evaluate so the
// pipeline can seed token generation from it.
if matched == len(inputs) && matched > 0 {
matchPath, matched = findBestMatch(c.root, keys[:matched-1])
}
// A match ending inside a non-causal media item resumes before it.
if item := insideAtomicItem(items, matched); item != nil {
matchPath, matched = findBestMatch(c.root, keys[:item.pos])
}
// Switch to the matched path, paging in/out as needed.
c.switchToPath(matchPath, matched)
// switchToPath aligns caches to a common offset
prefix := c.minCacheOffset()
remaining := inputs[prefix:]
session := &cacheSession{
cache: c,
inputs: inputs,
effInputs: effInputs,
items: items,
caches: c.caches,
remaining: remaining,
}
// Schedule a snapshot at the branch point during prefill so future
// requests diverging here can restore instead of re-evaluating.
if prefix < matched {
session.pendingSnapshots = append(session.pendingSnapshots, pendingSnapshot{offset: matched, user: false})
}
msg := "cache hit"
if prefix == 0 {
msg = "cache miss"
}
slog.Info(msg, "total", len(inputs), "matched", originalMatched, "cached", prefix, "left", len(remaining))
return session
}
// insideAtomicItem returns the non-causal media item that offset lies strictly
// inside, or nil.
func insideAtomicItem(items []mediaItem, offset int) *mediaItem {
for i := range items {
item := &items[i]
if item.atomic() && item.pos < offset && offset < item.pos+item.length {
return item
}
}
return nil
}
// effectiveKeyTokens returns the per-position key alphabet: the token ID
// outside media expansions, the item's fold value across each expansion's
// whole range.
func effectiveKeyTokens(tokens []int32, items []mediaItem) []uint32 {
eff := make([]uint32, len(tokens))
for i, t := range tokens {
eff[i] = uint32(t)
}
for _, item := range items {
for i := item.pos; i < item.pos+item.length; i++ {
eff[i] = item.fold
}
}
return eff
}
// key packs (token i, token i+1) per restorable offset: draft caches
// pair each slot with the next token, so matching k keys verifies k+1
// tokens and every match is a valid restore point.
func (c *prefixCache) key(tokens []uint32) []trieKey {
keys := make([]trieKey, max(len(tokens)-c.draftLookahead, 0))
switch c.draftLookahead {
case 0:
for i, t := range tokens {
keys[i] = trieKey(t)
}
case 1:
for i := range keys {
keys[i] = trieKey(tokens[i])<<32 | trieKey(tokens[i+1])
}
default:
panic(fmt.Sprintf("prefixCache: unsupported draft look-ahead %d", c.draftLookahead))
}
return keys
}
// storedKeys keys the session's evaluated stream: the prompt's effective
// tokens plus generated tokens, which are never media.
func (s *cacheSession) storedKeys() []trieKey {
eff := s.effInputs
if len(s.outputs) > 0 {
eff = make([]uint32, 0, len(s.effInputs)+len(s.outputs))
eff = append(eff, s.effInputs...)
for _, t := range s.outputs {
eff = append(eff, uint32(t))
}
}
return s.cache.key(eff)
}
// switchToPath transitions from the current active path to a new path,
// rewinding the caches and paging in the new path's snapshots.
func (c *prefixCache) switchToPath(newPath []*trieNode, matched int) {
defer c.enforceEvictionPolicy()
// Find common ancestor index.
commonLen := 0
for commonLen < len(c.activePath) && commonLen < len(newPath) {
if c.activePath[commonLen] != newPath[commonLen] {
break
}
commonLen++
}
ancestorOffset := 0
if commonLen > 0 {
ancestorOffset = c.activePath[commonLen-1].endOffset
}
var pageInCount int
// Rewind each cache to the target offset or free it. When matched
// falls within the ancestor's range (same-path case), we rewind
// directly to the match point. Otherwise we rewind to the ancestor
// and let page-in bring us forward to matched.
rewindTarget := min(ancestorOffset, matched)
for _, kv := range c.caches {
if kv == nil {
continue
}
if !kv.Restore(nil, rewindTarget) {
kv.Free()
}
}
// Page in — walk the full new path, restoring from snapshots.
// Freed caches naturally pick up the first available snapshot.
// Caches already past a node skip it via offset check.
pageIn:
for _, node := range newPath {
if !node.hasSnapshots() {
continue
}
nodeTarget := min(node.endOffset, matched)
for j, kv := range c.caches {
if kv == nil {
continue
}
if j >= len(node.snapshots) || node.snapshots[j] == nil {
continue
}
if kv.Offset() >= nodeTarget {
continue
}
if !kv.Restore(node.snapshots[j], nodeTarget) {
// Restore failed — stop page-in and let alignment
// bring all caches to a consistent offset.
break pageIn
}
}
if node.endOffset > ancestorOffset {
pageInCount++
logutil.Trace(fmt.Sprintf("page in: [%d, %d)", node.startOffset(), nodeTarget))
}
}
// Align all caches to the minimum offset.
c.activePath = newPath
minOff := c.minCacheOffset()
for _, kv := range c.caches {
if kv != nil && kv.Offset() != minOff {
if !kv.Restore(nil, minOff) {
slog.Warn("failed to restore cache, freeing all caches", "offset", minOff)
c.freeAll()
break
}
}
}
// If the live offset falls inside the last node, split it so the reused
// head stays on the active path and only the unused tail can be evicted.
for i := len(c.activePath) - 1; i >= 0; i-- {
node := c.activePath[i]
if i > 0 && node.startOffset() >= minOff {
continue
}
if node.endOffset > minOff {
node = splitNode(node, minOff-node.startOffset(), c.caches, &c.pagedOutBytes)
}
c.activePath = append(c.activePath[:i], node)
break
}
// Update last-used time on only the final used node. For recurrent
// caches we don't need the intermediate snapshots and for KV caches
// we can reslice the data out of merged edges.
if len(c.activePath) > 0 {
c.activePath[len(c.activePath)-1].lastUsed = time.Now()
}
if pageInCount > 0 {
slog.Debug("switching cache path", "page_in", pageInCount)
}
}
// schedulePrefillSnapshots schedules every cache to capture snapshots as the
// forward pass crosses the given absolute token offsets, so a single full-size
// prefill records interior states without the caller breaking the batch. A
// passed offset names a token prefix; the capture lands at the deepest
// state that prefix alone determines (offset - draftLookahead), which is where
// a prompt sharing exactly that prefix restores. An offset inside a non-causal
// media item's tokens moves past them. The offsets are merged with
// any snapshots begin already scheduled (e.g. a branch point), with coinciding
// offsets upgraded to user so compaction keeps them.
//
// Offsets at or before the current cache position, or past the end of the
// prompt, are dropped: callers only request offsets ahead of the prefill base,
// so this is a defensive guard.
func (s *cacheSession) schedulePrefillSnapshots(offsets []int) {
c := s.cache
base := c.minCacheOffset()
for _, offset := range offsets {
offset -= c.draftLookahead
if item := insideAtomicItem(s.items, offset); item != nil {
offset = item.pos + item.length
}
if offset <= base || offset > len(s.inputs) {
continue
}
// Deduplicate: if this offset already exists, upgrade to user.
found := false
for i := range s.pendingSnapshots {
if s.pendingSnapshots[i].offset == offset {
s.pendingSnapshots[i].user = true
found = true
break
}
}
if !found {
s.pendingSnapshots = append(s.pendingSnapshots, pendingSnapshot{offset: offset, user: true})
}
}
slices.SortFunc(s.pendingSnapshots, func(a, b pendingSnapshot) int {
return a.offset - b.offset
})
if len(s.pendingSnapshots) == 0 {
return
}
prepared := make([]int, len(s.pendingSnapshots))
for i, p := range s.pendingSnapshots {
prepared[i] = p.offset
}
for _, kv := range c.caches {
if kv != nil {
kv.PrepareSnapshots(prepared)
}
}
}
// attachPrefillSnapshots collects the snapshots captured during prefill and
// attaches them to the trie, materializing a node at each requested offset.
// Pending offsets are ascending and were scheduled in the same order, so the
// snapshots each cache returns line up with them. The trie frontier is
// advanced to each offset in turn, so its node edges [prev, offset) match the
// edge-local ranges the caches captured.
func (s *cacheSession) attachPrefillSnapshots() {
if len(s.pendingSnapshots) == 0 {
return
}
c := s.cache
pending := s.pendingSnapshots
s.pendingSnapshots = nil
// Drain each cache's captures (one per pending offset, in order) into
// per-offset rows.
rows := make([][]cache.Snapshot, len(pending))
for i := range rows {
rows[i] = make([]cache.Snapshot, len(c.caches))
}
for j, kv := range c.caches {
if kv == nil {
continue
}
taken := kv.TakeSnapshots()
for i := range pending {
if i < len(taken) {
rows[i][j] = taken[i]
}
}
}
// Prefill leaves one token unprocessed for decode seeding, so an offset
// at or past the live cache position was never crossed by a write and has
// no captured state. Skip it rather than materialize a node whose edge
// claims tokens the cache never wrote. Closing its (nil) row is a no-op.
reached := c.minCacheOffset()
stored := s.storedKeys()
for i, p := range pending {
if p.offset > reached {
// Never crossed by a write, so the row is nil; close any entry
// defensively in case a cache captured one anyway.
for _, snap := range rows[i] {
if snap != nil {
snap.Close()
}
}
continue
}
frontier := c.activePath[len(c.activePath)-1]
if frontier.endOffset < p.offset {
edgeTokens := stored[frontier.endOffset:p.offset]
frontier = c.advancePath(frontier, edgeTokens, p.offset)
}
if p.user {
frontier.user = true
}
s.attachCapturedSnapshots(frontier, rows[i])
c.compactPath()
}
c.enforceEvictionPolicy()
}
// attachCapturedSnapshots stores pre-captured snapshots on a trie node. Unlike
// taking a fresh Snapshot from the live cache, this works for an interior node
// whose offset the live cache has already advanced past: the snapshots come
// from the capture scheduled earlier, not from the cache's current state. The
// node takes ownership of the snapshots (TakeSnapshots already transferred it).
// Each capture is clipped to the node's edge, and a layer that already has a
// snapshot keeps it.
func (s *cacheSession) attachCapturedSnapshots(node *trieNode, snaps []cache.Snapshot) {
c := s.cache
next := make([]cache.Snapshot, len(c.caches))
copy(next, node.snapshots)
for i, kv := range c.caches {
if kv == nil || i >= len(snaps) || snaps[i] == nil {
continue
}
if next[i] != nil {
snaps[i].Close()
continue
}
head, tail := kv.Split(snaps[i], node.startOffset())
if head != nil {
head.Close()
}
next[i] = tail
}
for i, old := range node.swapSnapshots(next, &c.pagedOutBytes) {
if old != nil && old != next[i] {
old.Close()
}
}
node.lastUsed = time.Now()
slog.Debug("created snapshot", "offset", node.endOffset)
}
// advancePath advances the active path from the current frontier by matching
// tokens against existing trie children, splitting partial matches, and
// appending any remaining tokens as a new child node. Returns the new frontier.
func (c *prefixCache) advancePath(frontier *trieNode, tokens []trieKey, endOffset int) *trieNode {
// Check if existing children already cover some or all of tokens.
// tokens may span multiple trie nodes when extending a previous run's
// leaf and this snapshot now overlaps that same range.
matchPath, matched := findBestMatch(frontier, tokens)
// matchPath[0] is frontier itself; the rest are newly traversed nodes.
remaining := tokens[matched:]
// Check for a partial match within the last node's edge — if so, split it.
if len(matchPath) > 1 {
lastNode := matchPath[len(matchPath)-1]
matchedInEdge := frontier.endOffset + matched - lastNode.startOffset()
if matchedInEdge > 0 && matchedInEdge < len(lastNode.tokens) {
matchPath[len(matchPath)-1] = splitNode(lastNode, matchedInEdge, c.caches, &c.pagedOutBytes)
}
}
// Append traversed nodes (excluding frontier) to the active path.
c.activePath = append(c.activePath, matchPath[1:]...)
dest := matchPath[len(matchPath)-1]
if len(remaining) > 0 {
dest = dest.appendChild(remaining, endOffset)
c.activePath = append(c.activePath, dest)
}
return dest
}
// compactPath absorbs the active path's last node into its parent when the
// parent is a non-user node with no other children, keeping consecutive
// non-user segments compressed into one node.
func (c *prefixCache) compactPath() {
n := len(c.activePath)
if n < 2 {
return
}
parent := c.activePath[n-2]
if parent == c.root || parent.user || len(parent.children) != 1 {
return
}
mergeWithChild(parent, c.caches, &c.pagedOutBytes)
c.activePath = c.activePath[:n-1]
}
// pageOut captures the snapshots a node is missing from the live caches, which
// rest exactly at its end.
func (c *prefixCache) pageOut(node *trieNode) {
if hasAllSnapshots(node, c.caches) {
return
}
snaps := make([]cache.Snapshot, len(c.caches))
copy(snaps, node.snapshots)
for i, kv := range c.caches {
if kv == nil || snaps[i] != nil {
continue
}
snaps[i] = kv.Snapshot(node.startOffset())
}
node.swapSnapshots(snaps, &c.pagedOutBytes)
logutil.Trace(fmt.Sprintf("page out: [%d, %d)", node.startOffset(), node.endOffset))
c.enforceEvictionPolicy()
}
// freeAll releases all cache layers.
func (c *prefixCache) freeAll() {
for _, kv := range c.caches {
if kv != nil {
kv.Free()
}
}
}
func (c *prefixCache) minCacheOffset() int {
offset := 0
found := false
for _, kv := range c.caches {
if kv == nil {
continue
}
if off := kv.Offset(); !found || off < offset {
offset = off
found = true
}
}
return offset
}
// close saves the token state if the forward pass ran.
func (s *cacheSession) close() {
// A cancelled prefill never reaches the success-path attach; attaching
// here keeps its crossed captures for the retry and drains the schedule
// PrepareSnapshots would otherwise overwrite, leaking them.
s.attachPrefillSnapshots()
offset := s.cache.minCacheOffset()
if offset <= 0 {
return
}
arrays := make([]*mlx.Array, 0, 2*len(s.caches))
for _, kv := range s.caches {
if kv == nil {
continue
}
arrays = append(arrays, kv.State()...)
}
// Ensure that if we have run the forward pass and set the metadata
// that we also actually have the data.
mlx.AsyncEval(arrays...)
// The caches never advance past the stored keys; anything more
// means positions desynced.
c := s.cache
stored := s.storedKeys()
if offset > len(stored) {
panic(fmt.Sprintf("cache: offset %d exceeds %d stored keys", offset, len(stored)))
}
// Advance the trie frontier with any newly generated tokens and page
// the new segment out. Merging after the page-out combines covered
// snapshots.
if len(c.activePath) > 0 {
frontier := c.activePath[len(c.activePath)-1]
if offset > frontier.endOffset {
newTokens := stored[frontier.endOffset:offset]
c.pageOut(c.advancePath(frontier, newTokens, offset))
c.compactPath()
}
c.activePath[len(c.activePath)-1].lastUsed = time.Now()
}
}
// enforceEvictionPolicy evicts eligible nodes until paged-out memory is within limits.
func (c *prefixCache) enforceEvictionPolicy() {
if c.pagedOutBytes <= maxPagedOutBytes {
return
}
activeSet := make(map[*trieNode]bool, len(c.activePath))
for _, n := range c.activePath {
activeSet[n] = true
}
for c.pagedOutBytes > maxPagedOutBytes {
var best *trieNode
walkNodes(c.root, func(n *trieNode) bool {
if n == c.root || activeSet[n] || len(n.children) > 1 {
return true
}
// Evict: oldest, then deepest, then largest.
if best == nil || cmp.Or(
n.lastUsed.Compare(best.lastUsed),
cmp.Compare(best.endOffset, n.endOffset),
cmp.Compare(best.snapshotBytes(), n.snapshotBytes()),
) < 0 {
best = n
}
return true
})
if best == nil {
break
}
c.evictNode(best)
}
}
// evictNode evicts a single node from the trie, freeing its snapshot memory.
func (c *prefixCache) evictNode(node *trieNode) {
if len(node.children) == 0 {
// Leaf: remove entirely.
slog.Debug("evicting leaf", "offset", node.startOffset(), "tokens", len(node.tokens), "freed", mlx.PrettyBytes(int(node.snapshotBytes())))
removeNode(node, &c.pagedOutBytes)
} else if len(node.children) == 1 {
// Interior node with one child: merge with child.
before := c.pagedOutBytes
tokens := len(node.tokens)
mergeWithChild(node, c.caches, &c.pagedOutBytes)
slog.Debug("evicting interior node", "offset", node.startOffset(), "tokens", tokens, "freed", mlx.PrettyBytes(int(before-c.pagedOutBytes)))
} else {
panic("evictNode called on multi-child branch point")
}
}
func (c *prefixCache) dumpTree() {
// Summary stats
var cacheBytes int
for _, kv := range c.caches {
if kv == nil {
continue
}
for _, a := range kv.State() {
if a != nil {
cacheBytes += a.NumBytes()
}
}
}
// Build active path set for marking.
active := make(map[*trieNode]bool, len(c.activePath))
for _, n := range c.activePath {
active[n] = true
}
var nodeCount, snapshotCount int
var pagedBytes int64
var lines []string
var dump func(n *trieNode, prefix string, isLast bool)
dump = func(n *trieNode, prefix string, isLast bool) {
if n == nil {
return
}
nodeCount++
// Build connector
var connector string
if n.parent == nil {
connector = ""
} else if isLast {
connector = prefix + "`-- "
} else {
connector = prefix + "|-- "
}
// Node label
nodeBytes := n.snapshotBytes()
pagedBytes += nodeBytes
label := fmt.Sprintf("[%d,%d) %dt", n.startOffset(), n.endOffset, len(n.tokens))
if nodeBytes > 0 {
label += " " + mlx.PrettyBytes(int(nodeBytes)).String()
}
if !n.lastUsed.IsZero() {
label += fmt.Sprintf(" %s ago", time.Since(n.lastUsed).Truncate(time.Millisecond))
}
var flags []string
if n.user {
flags = append(flags, "user")
}
if hasAllSnapshots(n, c.caches) {
snapshotCount++
flags = append(flags, "snap")
}
if active[n] {
flags = append(flags, "active")
}
if len(flags) > 0 {
label += " (" + flags[0]
for _, f := range flags[1:] {
label += ", " + f
}
label += ")"
}
lines = append(lines, connector+label)
// Recurse children
childPrefix := prefix
if n.parent != nil {
if isLast {
childPrefix += " "
} else {
childPrefix += "| "
}
}
for i, child := range n.children {
dump(child, childPrefix, i == len(n.children)-1)
}
}
dump(c.root, "", true)
offset := c.minCacheOffset()
logutil.Trace(fmt.Sprintf("prefix cache active_tokens: %d, active_size: %s, paged_out: %s, trie: nodes=%d, snapshots=%d",
offset, mlx.PrettyBytes(cacheBytes), mlx.PrettyBytes(int(pagedBytes)), nodeCount, snapshotCount))
for i, l := range lines {
if i == 0 {
logutil.Trace("cache trie: " + l)
} else {
logutil.Trace(" " + l)
}
}
}