From 5ae56b3777cb22a2cdff265bb7ff205e3908df9f Mon Sep 17 00:00:00 2001 From: Arnaud Gourlay Date: Thu, 15 May 2025 21:41:30 +0200 Subject: [PATCH] Fix unecessary unsafe in Clippy 1.87 (#6540) * Fix unecessary unsafe in Clippy 1.87 * bump Rust version for intrinsics safe API * ignore until we can bump the MSRV with cargo-chef * remove unecessary change * mark clearly as TODO --- lib/segment/src/spaces/simple_avx.rs | 1 + lib/segment/src/spaces/simple_sse.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/segment/src/spaces/simple_avx.rs b/lib/segment/src/spaces/simple_avx.rs index 7d8c0f6365..dd7f3bad30 100644 --- a/lib/segment/src/spaces/simple_avx.rs +++ b/lib/segment/src/spaces/simple_avx.rs @@ -8,6 +8,7 @@ use crate::data_types::vectors::{DenseVector, VectorElementType}; #[target_feature(enable = "avx")] #[target_feature(enable = "fma")] #[allow(clippy::missing_safety_doc)] +#[allow(unused_unsafe)] // TODO remove once we can bump the MSRV to 1.87 (cargo-chef) pub unsafe fn hsum256_ps_avx(x: __m256) -> f32 { unsafe { let x128: __m128 = _mm_add_ps(_mm256_extractf128_ps(x, 1), _mm256_castps256_ps128(x)); diff --git a/lib/segment/src/spaces/simple_sse.rs b/lib/segment/src/spaces/simple_sse.rs index 607b5e3019..a2cf4a5f1f 100644 --- a/lib/segment/src/spaces/simple_sse.rs +++ b/lib/segment/src/spaces/simple_sse.rs @@ -10,6 +10,7 @@ use crate::data_types::vectors::{DenseVector, VectorElementType}; #[target_feature(enable = "sse")] #[allow(clippy::missing_safety_doc)] +#[allow(unused_unsafe)] // TODO remove once we can bump the MSRV to 1.87 (cargo-chef) pub unsafe fn hsum128_ps_sse(x: __m128) -> f32 { unsafe { let x64: __m128 = _mm_add_ps(x, _mm_movehl_ps(x, x));