Arnaud Gourlay dd84044a3e refactor: replace StructPayloadIndex::open bool flags with StorageType and IndexLoadMode (#9754) ...

StructPayloadIndex::open took two adjacent bools (is_appendable, create)
and call sites passed every literal combination: (true, true),
(true, false) and (false, true) all exist. A transposed pair compiles
and silently yields e.g. non-appendable + create instead of
appendable + load-only.

The target enum already existed: open immediately converted the bool
into the private StorageType { Appendable, NonAppendable }, so the bool
survived only at the API boundary, exactly where the swap hazard lives.
Make StorageType public, take it directly, and introduce
IndexLoadMode { CreateIfMissing, LoadExisting } for the create flag.

create_segment had the same trailing create: bool with bare literals at
both callers, so its parameter is lifted to IndexLoadMode as well:
load_segment passes LoadExisting, build_segment passes CreateIfMissing.
No behavior change.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2026-07-14 10:47:43 +02:00

..

segment_constructor_base

refactor: replace StructPayloadIndex::open bool flags with StorageType and IndexLoadMode (#9754)

2026-07-14 10:47:43 +02:00

batched_reader.rs

[TQDT] Wire TQ multivectors storage (#9439)

2026-06-16 11:52:22 +02:00

mod.rs

[TQDT] Vector storage update from without CowVector (#9325)

2026-06-09 13:43:33 +02:00

segment_builder.rs

refactor: replace StructPayloadIndex::open bool flags with StorageType and IndexLoadMode (#9754)

2026-07-14 10:47:43 +02:00

simple_segment_constructor.rs

Rename ambiguous build_multivec_segment test fixture (#9713)

2026-07-08 11:52:10 +02:00