mirror of
https://github.com/qdrant/qdrant.git
synced 2026-07-27 13:11:06 -05:00
* feat(debug): QDRANT_APPEND_ONLY_MUTATIONS env override Debug-only escape hatch so newly built segments default to append-only mutation routing when QDRANT_APPEND_ONLY_MUTATIONS=1 (or true/yes) is set in the environment. Lets us run the existing test suites against the append-only path without wiring a collection-level config knob first. Release builds compile this out — the function is a const false. Logs a single warn-level message the first time the override fires. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(append-only): skip deleted vectors on snapshot, always write payload Two correctness fixes to clone_and_mutate_point uncovered by running the openapi suite with QDRANT_APPEND_ONLY_MUTATIONS=1: 1. The snapshot loop read every named vector via get_vector_opt, which returns slot bytes even when the per-vector deletion bit is set. For sparse-only points (or any point that had update_vector(_, None) applied) this materialised the default-zero vector as if it were real data, wrote it at new_id, and never re-tombstoned the slot — so dense search started scoring phantom vectors. Now we check is_deleted_vector(old_id) and skip the read, letting the writer loop emit update_vector(new_id, None) and re-mark the slot deleted. 2. The payload write was skipped when the snapshot ended up empty. That dropped two side effects the field indexes rely on: payload_storage.overwrite(new_id, empty), and the remove_point fan-out across configured field indexes that bumps each index's total_point_count to cover new_id. Without the bump the null index doesn't see new_id, so is_empty / is_null filters lose the point even though its mapping is live in the id tracker. The skip was an optimisation, not a contract; remove it so the field indexes get the same registration they'd get from the standard clear_payload path. Also collapses the debug env override to an inline cfg!()-gated check at the struct literal — the helper with one-time logging and multi-value matching was disproportionate for a debug-only escape hatch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(id_tracker): split active vs deferred maps in PointMappings (PR A) First step of moving the mutable id tracker to a "two-track" model so append-only mutations into a deferred segment can keep both the visible (active) version and the latest mutated (deferred) version of a point at the same time. This PR is purely structural. On-disk format is unchanged: the loader still produces a single combined map, and `PointMappings::new` partitions it at construction time based on `deferred_internal_id`. Every observable behaviour at the existing API surface is preserved. Concretely: - New fields: `external_to_internal_num_deferred`, `external_to_internal_uuid_deferred`, and a `shadowed: BitVec` for future use by PR B (lazy-grown, default-false). - `internal_id(ext)` checks active first, falls through to deferred — matches the pre-split "any matching id" contract for ext ids whose internal id sat above the cutoff. - `set_link(ext, new_id)` now routes by cutoff: writes below the cutoff land in active, writes at or above land in deferred. Any prior head in the other track is tombstoned, so each ext still owns exactly one slot — same observable result as the pre-split single-map insert. PR B replaces the cross-track tombstone with a shadow-bit flip; PR A keeps current semantics on purpose. - `drop(ext)` clears entries from both tracks and tombstones each one, again matching the prior single-map behaviour. - `iter_external` and `iter_from` merge the active and deferred BTreeMap views into one sorted-by-key stream (dedup'd in case an ext exists in both tracks). - `available_point_count` counts distinct external ids across both tracks — preserves the prior observable count for segments where some entries used to sit above the cutoff in the single map. No write-path or read-path behaviour change. Reads still filter `internal_id >= cutoff` exactly as before; mutations still tombstone prior heads. The shadow bit and the deferred-aware lookup wiring land in PR B and PR C. All existing id_tracker tests pass against the split layout. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(id_tracker): shadow active head on deferred writes (PR B) Step 2 of the deferred-aware mutable id tracker. Replaces PR A's "tombstone the other track" cross-track cleanup with shadow-bit logic so a deferred mutation no longer hides the visible active version. Behaviour by case: - Active write (`internal_id < cutoff`, or no cutoff): unchanged semantically. Any prior deferred head for the same ext is dropped and tombstoned (the new active is the single visible head). Same observable result as PR A. - Deferred write (`internal_id >= cutoff`): the prior deferred head (if any) is dropped and tombstoned. The active head, if it exists, is **shadowed** — its bit is set in `shadowed: BitVec` but its slot stays alive in the active map. Read paths in `Exclude` mode continue to return that active version; PR C will teach `IncludeAll` paths (the optimiser) to skip shadowed actives and prefer the deferred head. Also adds `is_shadowed(internal_id)` and `shadowed_bitslice()` accessors (the latter for PR C's filter pipeline). New unit tests cover the routing matrix: - no cutoff — active replacement, no shadow, - below-cutoff replacement — active path, no shadow, - deferred-on-top-of-active — shadow set, active retained, - two deferred writes — prior deferred tombstoned, shadow persists, - fresh insert above cutoff — no shadow, - `drop(ext)` clears both tracks plus the shadow bit. WAL replay reuses the same `set_link`, so deferred routing on replay falls out of this change with no extra wiring. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(id_tracker): IncludeAll skips shadowed actives, deferred-aware lookups (PR C) Step 3 of the deferred-aware id tracker stack. PR B introduced the shadow bit on `set_link`; this PR teaches the read paths to honour it so the optimiser (and any other `DeferredBehavior::IncludeAll` consumer) sees each external id exactly once, with the deferred head winning over the now-shadowed active. Concretely: - `PointMappings::internal_id_with_behavior(ext, behavior)`: * `Exclude` returns the active head only — `None` for a deferred-only ext, so query paths never see a deferred mutation; * `IncludeAll` prefers the deferred head and falls back to active for points that never crossed the cutoff. Yields at most one internal id per ext. - `IdTrackerRead::internal_id_with_behavior` mirrors the new method with a default impl that delegates to `internal_id` for trackers that don't carry deferred mutations. - `PointMappingsRefEnum::iter_internal_with_behavior(IncludeAll)` now filters shadowed actives via the new `PointMappings::shadowed_bitslice()` accessor. - `PointMappingsRefEnum::filter_deferred_and_deleted(IncludeAll)` also filters shadowed actives — same single-yield-per-external guarantee for external iterator sources like field-index outputs. - `IdTrackerRead::resolve_external_ids` switches to the deferred-aware lookup. No more post-lookup `id >= cutoff` filter — the behaviour enum lookup gets it right at the source. New unit tests cover the two new entry points: - IncludeAll prefers the deferred head when an active is shadowed; - Exclude returns None for deferred-only ext ids; - `filter_deferred_and_deleted` over a mixed candidate list yields the expected per-mode result (Exclude: actives below cutoff; IncludeAll: every visible head, no shadowed actives). No queries observable behaviour change today — production Exclude paths still resolve via `internal_id` and the active head. The optimiser will start using `IncludeAll` (and reap the dedup) in follow-up work. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(id_tracker): expose shadowed_point_count in SegmentInfo (PR D) Final step of the deferred-aware id tracker stack. Adds a single new counter — number of active heads currently shadowed by a deferred mutation — and plumbs it through the id-tracker trait, the segment read-view helper, and `SegmentInfo` for telemetry. Preserves existing semantics: - `available_point_count` is unchanged. Each distinct external id still counts once, regardless of which track holds its head. - `deferred_point_count`, `deferred_internal_id`, `num_deleted_deferred_points` keep their current values. - Non-appendable trackers default `shadowed_point_count()` to `0`, so the new `SegmentInfo.num_shadowed_points` is `None` for them. Concrete changes: - `PointMappings::shadowed_count()` — popcount of the shadowed bitslice. - `IdTrackerRead::shadowed_point_count()` trait method with a `0` default; wired through `MutableIdTracker`, `InMemoryIdTracker`, the mutable read-only tracker, and both enum dispatchers. - `SegmentReadView::shadowed_point_count()` helper. - New `SegmentInfo.num_shadowed_points: Option<usize>`, populated with `Some(_)` for appendable segments and proxied through `ProxySegment` from the wrapped segment's value. New unit test covers the counter lifecycle: - active-only writes don't grow it, - a deferred write over an active adds one shadow, - a second deferred write supersedes the prior deferred head but the shadow stays put (still one active being shadowed), - `drop(ext)` clears the shadow bit, - a fresh deferred insert with no active prior doesn't add a shadow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(id_tracker): rename DeferredBehavior, push behavior down to PointMappings Three connected pieces of polish on top of the deferred-aware id tracker stack: 1. Rename `DeferredBehavior::Exclude` → `VisibleOnly` and `IncludeAll` → `WithDeferred`. The pre-PR-C semantics of "include/exclude the deferred cutoff" became misleading once `IncludeAll` started skipping shadowed actives — it doesn't "include all" anymore, it yields one slot per external (deferred head preferred, active fallback). New names describe what each variant returns instead of how it relates to the cutoff. The helper method `include_all_points` becomes `with_deferred_points`. Updates ~90 call sites across the workspace; behaviour is unchanged. 2. Push `iter_internal_with_behavior` down from `PointMappingsRefEnum` into `PointMappings`. The per-mode logic (cutoff `take_while`, shadowed `filter`) now lives next to the data it consults; the enum layer becomes a two-arm `Either` dispatcher. `CompressedPointMappings` short-circuits to `iter_internal()` since compressed mappings can't carry deferred mutations. 3. Add a short docstring on `internal_to_external` describing the two-track model: no active-vs-deferred bias, shadowed pairs occupy two slots with the same value, and reads must gate on `deleted` because `set_link`'s same-track replacement leaves a real-looking stale ext id in place. Returning `impl Iterator` instead of `Box<dyn Iterator>` for `iter_internal`, `iter_internal_excluding`, `iter_internal_visible`, and `iter_internal_with_behavior` removes the double-Box at the enum boundary. The original branching structure is preserved with `itertools::Either` instead of restructured into one big filter chain. All existing `id_tracker` tests still pass (47 total). `cargo check --all-targets` + `cargo clippy --all-targets` clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(id_tracker): drop shadowed API surface, unbox iter_from/iter_random Cleanup pass on top of the deferred-aware id tracker stack. API surface: - Drop SegmentInfo.num_shadowed_points + its trait method, read-view helper, tracker impls and ProxySegment passthrough. Cross-segment shadow already exists in the appendable update flow (the source segment keeps its copy when the new write lands above the cutoff, see SegmentHolder::apply_points_with_conditional_move) and is handled at the aggregation layer, not reported per-tracker. - Keep PointMappings::shadowed_count() as a private popcount helper guarded by expect(dead_code) so a future caller can opt back into the dedup'd count without re-plumbing the trait. available_point_count: - Replace the cross-track dedup (active + deferred-only via contains_key filter) with a straight 4-term sum. A shadowed ext contributes two slots, matching the two non-tombstoned internal ids it actually occupies. Old dedup broke the invariant that deleted_point_count == deleted_bitslice.count_ones(): for each shadow it overcounted deletions by one without any tombstone actually being set. DeferredBehavior pushdown: - iter_random_with_behavior: caps the sampling range at the deferred threshold in VisibleOnly mode (no wasted samples above cutoff), filters shadowed actives via the bit in WithDeferred. - iter_from_with_behavior: VisibleOnly walks the active maps only (no merge with deferred); WithDeferred delegates to iter_from's existing merge. - scroll.rs read_by_id_stream / filtered_read_by_id_stream collapse their manual if-deferred-behavior branching into a single iter_from_with_behavior call. - Old iter_random (no behavior) at PointMappings + ref enum was unused after the migration, deleted. Unboxing iter_from / iter_random / iter_from_with_behavior: - PointMappings::iter_from returns impl Iterator + '_ via Either inside the merged_num/merged_uuid closures (BTreeMap::iter vs range), Either at the outer match (num+uuid chain vs uuid-only). - PointMappings::iter_from_with_behavior unboxed with a triple Either (behavior, external-id arm, closure start). - CompressedPointMappings::iter_from unboxed (Either over None/Some). - PointMappingsRefEnum::{iter_from, iter_from_with_behavior, iter_from_visible} all return impl Iterator + 'a via Either on the Plain/Compressed dispatch. Other: - Update outdated PR-A/PR-B comment on PointMappings::drop. - Make the max_internal match in iter_random_with_behavior exhaustive (VisibleOnly+None | WithDeferred+_ instead of `_`). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(id_tracker): unbox iter_external Return impl Iterator from PointMappings::iter_external, CompressedPointMappings::iter_external and the PointMappingsRefEnum wrapper, matching the style of the other iter_* helpers. The wrapper dispatches via Either. The remaining Box::new at Segment::iter_points stays because self_cell's BoxedPointIdIterator alias needs a sized type. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(id_tracker): count set_link tombstones in deferred_deleted_count PointMappings::set_link tombstones the prior slot at two sites — when an active write supersedes a deferred head (cross-track) and when any write replaces a same-track head — using a bare deleted.set(old, true). Neither path updated deferred_deleted_count, so tombstones above the cutoff weren't reflected in the counter. The append-only flow exposes this constantly: every set_full_payload after upsert_point routes through clone_and_mutate_point, which re-issues set_link with a fresh internal id and tombstones the prior one. Most tombstones land above the cutoff, so deferred_point_count (total - cutoff - deferred_deleted_count) over-reports by the missing count. The openapi test_deferred_points integration test caught this as `num_points - num_deferred_points = -1800` across two segments. Extracted the tombstone bookkeeping into PointMappings::tombstone_slot and routed both set_link sites + drop's loop through it. Behaviour on drop is unchanged; set_link now bumps the counter on the live → tombstoned transition for slots at or above the cutoff. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * style(id_tracker): collapse set_link tombstone if-let chains Clippy's collapsible_if on the two if-let blocks added by the deferred_deleted_count fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Update lib/segment/src/id_tracker/point_mappings.rs Co-authored-by: Tim Visée <tim+github@visee.me> * refactor(id_tracker): size shadowed BitVec once instead of growing lazily Collect the shadowed active ids up front and allocate the BitVec to the highest offset in a single resize, avoiding repeated reallocations while marking shadows. Addresses review feedback. Co-authored-by: Cursor <cursoragent@cursor.com> * revert: restore lazily-grown shadowed BitVec Roll back the up-front sizing of the shadowed BitVec; last_entry doesn't fit here and swapping one allocation for another isn't worthwhile. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(id_tracker): prefer deferred head in iter_from merge When an external id has both an active and a deferred head, iter_from's merge collapsed the pair to the active (stale) offset. That contradicts the WithDeferred contract used everywhere else: internal_id_with_behavior and iter_random_with_behavior both surface the deferred head (the latest mutation) over the shadowed active. Consumers that use the returned internal id (payload-filter checks, the optimizer's version merge, HNSW old->new mapping) therefore saw the stale copy. Flip the Both arm to take the deferred operand and document the rule. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(id_tracker): preserve active+deferred heads when loading mappings read_mappings replayed the persisted change log into a single flat external -> internal map per id-type, then split it by the deferred cutoff in PointMappings::new. A flat map holds one head per external id, so it collapsed the active+deferred coexistence case (an external id linked first to an active slot, then to a deferred one via sequential set_link) down to the last write — silently dropping the other head, orphaning its slot, and leaving the shadowed bit unset. The split in new() could not recover what was already lost before it. Replay the log through the canonical set_link/drop mutators on a PointMappings seeded with the cutoff instead. The log is the sequence of set_link/drop calls that produced the live in-memory state, so this reconstructs that state exactly — both heads, the shadowed bit, and deferred_deleted_count — with no logic duplication. Drops the debug_assert-guarded corruption-recovery branch (subsumed by set_link's re-link handling) and the now-unused Uuid/PointIdType imports. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(id_tracker): make deferred behavior explicit at point resolution Replace the ambiguous "any matching head" point resolution with an explicit DeferredBehavior at every resolution boundary, so callers no longer rely on a hidden active-vs-deferred policy. - Remove PointMappings::internal_id and the bare IdTrackerRead::internal_id (the active-first-else-deferred hybrid). internal_id_with_behavior is now the single required resolution method; immutable/compressed trackers implement it by ignoring the behavior (they never carry deferred heads). - Migrate every caller to an explicit behavior, audit-driven: - writes (upsert/delete/payload/vectors), point_version, point_is_deferred, get_internal_id, drop, consistency + builder dedup -> WithDeferred (the latest/live head); - single-point payload/vector retrieval and formula rescore -> VisibleOnly; - HasId/CustomIdChecker/cardinality resolution -> the request's behavior, threaded through the filter chain from iter_filtered_points (other entry points default to VisibleOnly). - lookup_internal_id takes an explicit DeferredBehavior instead of assuming VisibleOnly internally. - has_point takes an explicit DeferredBehavior (drop the has_point_with_behavior wrapper). Thread it through read_points/_read_points/read_points_locked so retrieve_blocking passes its request behavior to the existence filter; all other existence/dedup callers pass WithDeferred (unchanged behavior). - set_link now detaches a stale live occupant of a reused internal id, keeping the forward and reverse maps consistent when recovering a corrupted log. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(id_tracker): failing tests for two correctness findings in #9249 (#9311) * test(id_tracker): failing tests for two review findings Two intentionally-failing tests pinning correctness gaps in the deferred-aware id tracker (#9249). Both fail on the final assertion; the earlier assertions establish the expected/consistent behavior. 1. iter_from_with_behavior(WithDeferred) resolves an active/deferred shadow collision to the stale ACTIVE internal id, while its siblings internal_id_with_behavior and iter_internal_with_behavior correctly surface the DEFERRED (latest) head. Consumers that use the yielded internal id (optimizer merge via for_each_unique_point, filtered_read_by_id_stream) therefore observe the pre-mutation version. left: [(NumId(7), 2)] right: [(NumId(7), 9)] 2. The PR-B shadow/visible invariant is not durable: the on-disk single combined map cannot represent a shadowed ext, so a plain mappings flush + reload collapses the shadow to deferred-only and the visible (active) head is lost (VisibleOnly resolves None where it resolved Some(2) live). Restoration then depends entirely on WAL replay, i.e. on flush-vs-WAL-truncate ordering. left: None right: Some(2) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(id_tracker): strengthen shadow tests + merge-primitive proof Follow-up to the two failing tests, addressing self-review: - Add for_each_unique_point_keeps_deferred_head_for_shadowed_point: the optimizer merge primitive (used by segment_builder::update_from) yields the stale active copy (internal 2, version 5) for a shadowed point and drops the deferred latest (internal 9, version 8). This directly exercises the data-loss consequence of finding #1 at the merge layer. left: [(NumId(7), 2, 5)] right: [(NumId(7), 9, 8)] - Tighten shadow_visible_head_survives_mapping_flush_reload: pin the exact reload failure mode. After flush+reload the mapping collapses to deferred-only (internal_id == Some(9)) and the active slot survives as a live orphan in the inverse map (external_id(2) == Some(7), not deleted) — a torn state where a VisibleOnly scroll still surfaces the stale copy while by-id VisibleOnly resolution breaks. Reframe as the live-vs-reload divergence the PR introduces (Some(2) live -> None reload; dev is consistently None). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix test --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: generall <andrey@vasnetsov.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: Tim Visée <tim+github@visee.me> Co-authored-by: root <111755117+qdrant-cloud-bot@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Arnaud Gourlay <arnaud.gourlay@gmail.com>
400 lines
12 KiB
Rust
400 lines
12 KiB
Rust
use std::iter::FromIterator;
|
|
use std::path::PathBuf;
|
|
use std::sync::atomic::AtomicBool;
|
|
|
|
use ahash::AHashSet;
|
|
use common::counter::hardware_counter::HardwareCounterCell;
|
|
use fs_err as fs;
|
|
use itertools::Itertools;
|
|
use segment::common::operation_error::OperationError;
|
|
use segment::data_types::named_vectors::NamedVectors;
|
|
use segment::data_types::vectors::{
|
|
DEFAULT_VECTOR_NAME, VectorRef, VectorStructInternal, only_default_vector,
|
|
};
|
|
use segment::entry::StorageSegmentEntry as _;
|
|
use segment::entry::entry_point::{NonAppendableSegmentEntry as _, ReadSegmentEntry, SegmentEntry};
|
|
use segment::fixtures::index_fixtures::random_vector;
|
|
use segment::segment_constructor::simple_segment_constructor::build_simple_segment;
|
|
use segment::segment_constructor::{load_segment, normalize_segment_dir};
|
|
use segment::types::{Condition, Distance, Filter, SearchParams, SegmentType, WithPayload};
|
|
use tempfile::{Builder, TempDir};
|
|
use uuid::Uuid;
|
|
|
|
use crate::fixtures::segment::{build_segment_1, build_segment_3};
|
|
|
|
#[test]
|
|
fn test_point_exclusion() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
|
|
let segment = build_segment_1(dir.path());
|
|
|
|
assert!(segment.has_point(3.into(), common::types::DeferredBehavior::WithDeferred));
|
|
|
|
let query_vector = [1.0, 1.0, 1.0, 1.0].into();
|
|
|
|
let res = segment
|
|
.search(
|
|
DEFAULT_VECTOR_NAME,
|
|
&query_vector,
|
|
&WithPayload::default(),
|
|
&false.into(),
|
|
None,
|
|
1,
|
|
None,
|
|
)
|
|
.unwrap();
|
|
|
|
let best_match = res.first().expect("Non-empty result");
|
|
assert_eq!(best_match.id, 3.into());
|
|
|
|
let ids: AHashSet<_> = AHashSet::from_iter([3.into()]);
|
|
|
|
let frt = Filter::new_must_not(Condition::HasId(ids.into()));
|
|
|
|
let res = segment
|
|
.search(
|
|
DEFAULT_VECTOR_NAME,
|
|
&query_vector,
|
|
&WithPayload::default(),
|
|
&false.into(),
|
|
Some(&frt),
|
|
1,
|
|
None,
|
|
)
|
|
.unwrap();
|
|
|
|
let best_match = res.first().expect("Non-empty result");
|
|
assert_ne!(best_match.id, 3.into());
|
|
|
|
let point_ids1: Vec<_> = segment.iter_points().collect();
|
|
let point_ids2: Vec<_> = segment.iter_points().collect();
|
|
|
|
assert!(!point_ids1.is_empty());
|
|
assert!(!point_ids2.is_empty());
|
|
|
|
assert_eq!(&point_ids1, &point_ids2)
|
|
}
|
|
|
|
#[test]
|
|
fn test_named_vector_search() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
|
|
let segment = build_segment_3(dir.path());
|
|
|
|
assert!(segment.has_point(3.into(), common::types::DeferredBehavior::WithDeferred));
|
|
|
|
let query_vector = [1.0, 1.0, 1.0, 1.0].into();
|
|
|
|
let res = segment
|
|
.search(
|
|
"vector1",
|
|
&query_vector,
|
|
&WithPayload::default(),
|
|
&false.into(),
|
|
None,
|
|
1,
|
|
None,
|
|
)
|
|
.unwrap();
|
|
|
|
let best_match = res.first().expect("Non-empty result");
|
|
assert_eq!(best_match.id, 3.into());
|
|
|
|
let ids: AHashSet<_> = AHashSet::from_iter([3.into()]);
|
|
|
|
let frt = Filter {
|
|
should: None,
|
|
min_should: None,
|
|
must: None,
|
|
must_not: Some(vec![Condition::HasId(ids.into())]),
|
|
};
|
|
|
|
let res = segment
|
|
.search(
|
|
"vector1",
|
|
&query_vector,
|
|
&WithPayload::default(),
|
|
&false.into(),
|
|
Some(&frt),
|
|
1,
|
|
None,
|
|
)
|
|
.unwrap();
|
|
|
|
let best_match = res.first().expect("Non-empty result");
|
|
assert_ne!(best_match.id, 3.into());
|
|
|
|
let point_ids1: Vec<_> = segment.iter_points().collect();
|
|
let point_ids2: Vec<_> = segment.iter_points().collect();
|
|
|
|
assert!(!point_ids1.is_empty());
|
|
assert!(!point_ids2.is_empty());
|
|
|
|
assert_eq!(&point_ids1, &point_ids2)
|
|
}
|
|
|
|
#[test]
|
|
fn test_missed_vector_name() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
let mut segment = build_segment_3(dir.path());
|
|
|
|
let hw_counter = HardwareCounterCell::new();
|
|
|
|
let exists = segment
|
|
.upsert_point(
|
|
7,
|
|
1.into(),
|
|
NamedVectors::from_pairs([
|
|
("vector2".into(), vec![10.]),
|
|
("vector3".into(), vec![5., 6., 7., 8.]),
|
|
]),
|
|
&hw_counter,
|
|
)
|
|
.unwrap();
|
|
assert!(exists, "this partial vector should overwrite existing");
|
|
|
|
let exists = segment
|
|
.upsert_point(
|
|
8,
|
|
6.into(),
|
|
NamedVectors::from_pairs([
|
|
("vector2".into(), vec![10.]),
|
|
("vector3".into(), vec![5., 6., 7., 8.]),
|
|
]),
|
|
&hw_counter,
|
|
)
|
|
.unwrap();
|
|
assert!(!exists, "this partial vector should not existing");
|
|
}
|
|
|
|
#[test]
|
|
fn test_vector_name_not_exists() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
let mut segment = build_segment_3(dir.path());
|
|
|
|
let hw_counter = HardwareCounterCell::new();
|
|
|
|
let result = segment.upsert_point(
|
|
6,
|
|
6.into(),
|
|
NamedVectors::from_pairs([
|
|
("vector1".into(), vec![5., 6., 7., 8.]),
|
|
("vector2".into(), vec![10.]),
|
|
("vector3".into(), vec![5., 6., 7., 8.]),
|
|
("vector4".into(), vec![5., 6., 7., 8.]),
|
|
]),
|
|
&hw_counter,
|
|
);
|
|
|
|
if let Err(OperationError::VectorNameNotExists { received_name }) = result {
|
|
assert_eq!(received_name, "vector4");
|
|
} else {
|
|
panic!("wrong upsert result")
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn ordered_deletion_test() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
|
|
let hw_counter = HardwareCounterCell::new();
|
|
|
|
let path = {
|
|
let mut segment = build_segment_1(dir.path());
|
|
segment.delete_point(6, 5.into(), &hw_counter).unwrap();
|
|
segment.delete_point(6, 4.into(), &hw_counter).unwrap();
|
|
segment.flush(false).unwrap();
|
|
segment.segment_path.clone()
|
|
};
|
|
|
|
let segment = load_segment(&path, Uuid::nil(), None, &AtomicBool::new(false)).unwrap();
|
|
let query_vector = [1.0, 1.0, 1.0, 1.0].into();
|
|
|
|
let res = segment
|
|
.search(
|
|
DEFAULT_VECTOR_NAME,
|
|
&query_vector,
|
|
&WithPayload::default(),
|
|
&false.into(),
|
|
None,
|
|
1,
|
|
None,
|
|
)
|
|
.unwrap();
|
|
let best_match = res.first().expect("Non-empty result");
|
|
assert_eq!(best_match.id, 3.into());
|
|
}
|
|
|
|
mod normalize_segment_dir {
|
|
use super::*;
|
|
|
|
fn make_segment() -> (TempDir, PathBuf, Uuid) {
|
|
let tmpdir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
let segment = build_segment_1(tmpdir.path());
|
|
(tmpdir, segment.segment_path.clone(), segment.uuid)
|
|
}
|
|
|
|
#[test]
|
|
fn happy_case() {
|
|
let (_tmpdir, original_path, original_uuid) = make_segment();
|
|
let result = normalize_segment_dir(&original_path).unwrap();
|
|
assert_eq!(Some((original_path, original_uuid)), result);
|
|
}
|
|
|
|
#[test]
|
|
fn deleted_suffix_case() {
|
|
let (tmpdir, original_path, _original_uuid) = make_segment();
|
|
let deleted_path = original_path.with_extension("deleted");
|
|
fs::rename(&original_path, &deleted_path).unwrap();
|
|
assert!(normalize_segment_dir(&deleted_path).unwrap().is_none());
|
|
assert!(fs::read_dir(tmpdir.path()).unwrap().next().is_none());
|
|
}
|
|
|
|
#[test]
|
|
fn missing_version_case() {
|
|
let (tmpdir, original_path, _original_uuid) = make_segment();
|
|
fs::remove_file(original_path.join(common::storage_version::VERSION_FILE)).unwrap();
|
|
assert!(normalize_segment_dir(&original_path).unwrap().is_none());
|
|
assert!(fs::read_dir(tmpdir.path()).unwrap().next().is_none());
|
|
}
|
|
|
|
#[test]
|
|
fn non_uuid_case() {
|
|
let (tmpdir, original_path, original_uuid) = make_segment();
|
|
let non_uuid_path = original_path.with_file_name("not-an-uuid");
|
|
fs::rename(&original_path, &non_uuid_path).unwrap();
|
|
let (normalized_path, normalized_uuid) =
|
|
normalize_segment_dir(&non_uuid_path).unwrap().unwrap();
|
|
let expected_path = tmpdir.path().join(normalized_uuid.to_string());
|
|
assert_ne!(normalized_uuid, original_uuid);
|
|
assert_eq!(normalized_path, expected_path);
|
|
assert!(fs::read_dir(&normalized_path).is_ok());
|
|
assert!(fs::read_dir(&non_uuid_path).is_err());
|
|
|
|
// Check idempotency
|
|
let result = normalize_segment_dir(&normalized_path).unwrap();
|
|
assert_eq!(Some((normalized_path, normalized_uuid)), result);
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn test_update_named_vector() {
|
|
let num_points = 25;
|
|
let dim = 4;
|
|
let mut rng = rand::rng();
|
|
let distance = Distance::Cosine;
|
|
let vectors = (0..num_points)
|
|
.map(|_| random_vector(&mut rng, dim))
|
|
.collect_vec();
|
|
|
|
let hw_counter = HardwareCounterCell::new();
|
|
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
let mut segment = build_simple_segment(dir.path(), dim, distance).unwrap();
|
|
|
|
for (i, vec) in vectors.iter().enumerate() {
|
|
let i = i as u64;
|
|
segment
|
|
.upsert_point(i, i.into(), only_default_vector(vec), &hw_counter)
|
|
.unwrap();
|
|
}
|
|
|
|
let query_vector = random_vector(&mut rng, dim).into();
|
|
|
|
// do exact search
|
|
let search_params = SearchParams {
|
|
exact: true,
|
|
..Default::default()
|
|
};
|
|
let nearest_upsert = segment
|
|
.search(
|
|
DEFAULT_VECTOR_NAME,
|
|
&query_vector,
|
|
&false.into(),
|
|
&true.into(),
|
|
None,
|
|
1,
|
|
Some(&search_params),
|
|
)
|
|
.unwrap();
|
|
let nearest_upsert = nearest_upsert.first().unwrap();
|
|
|
|
let sqrt_distance = |v: &[f32]| -> f32 { v.iter().map(|x| x * x).sum::<f32>().sqrt() };
|
|
|
|
// check if nearest_upsert is normalized
|
|
match &nearest_upsert.vector {
|
|
Some(VectorStructInternal::Single(v)) => {
|
|
assert!((sqrt_distance(v) - 1.).abs() < 1e-5);
|
|
}
|
|
Some(VectorStructInternal::Named(v)) => {
|
|
let v: VectorRef = (&v[DEFAULT_VECTOR_NAME]).into();
|
|
let v: &[_] = v.try_into().unwrap();
|
|
assert!((sqrt_distance(v) - 1.).abs() < 1e-5);
|
|
}
|
|
_ => panic!("unexpected vector type"),
|
|
}
|
|
|
|
// update vector using the same values
|
|
for (i, vec) in vectors.iter().enumerate() {
|
|
let i = i as u64;
|
|
segment
|
|
.update_vectors(
|
|
i + num_points as u64,
|
|
i.into(),
|
|
only_default_vector(vec),
|
|
&hw_counter,
|
|
)
|
|
.unwrap();
|
|
}
|
|
|
|
// do search after update
|
|
let nearest_update = segment
|
|
.search(
|
|
DEFAULT_VECTOR_NAME,
|
|
&query_vector,
|
|
&false.into(),
|
|
&true.into(),
|
|
None,
|
|
1,
|
|
Some(&search_params),
|
|
)
|
|
.unwrap();
|
|
let nearest_update = nearest_update.first().unwrap();
|
|
|
|
// check that nearest_upsert is normalized
|
|
match &nearest_update.vector {
|
|
Some(VectorStructInternal::Single(v)) => {
|
|
assert!((sqrt_distance(v) - 1.).abs() < 1e-5);
|
|
}
|
|
Some(VectorStructInternal::Named(v)) => {
|
|
let v: VectorRef = (&v[DEFAULT_VECTOR_NAME]).into();
|
|
let v: &[_] = v.try_into().unwrap();
|
|
assert!((sqrt_distance(v) - 1.).abs() < 1e-5);
|
|
}
|
|
_ => panic!("unexpected vector type"),
|
|
}
|
|
|
|
// check that nearests are the same
|
|
assert_eq!(nearest_upsert.id, nearest_update.id);
|
|
}
|
|
|
|
#[test]
|
|
fn test_plain_search_top_zero() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
|
|
let segment = build_segment_1(dir.path());
|
|
assert_eq!(segment.segment_type(), SegmentType::Plain);
|
|
|
|
segment
|
|
.search(
|
|
DEFAULT_VECTOR_NAME,
|
|
&[1.0, 1.0, 1.0, 1.0].into(),
|
|
&WithPayload::default(),
|
|
&false.into(),
|
|
None,
|
|
0,
|
|
None,
|
|
)
|
|
.unwrap();
|
|
}
|