mirror of
https://github.com/qdrant/qdrant.git
synced 2026-07-30 22:51:00 -05:00
9efc061764
* ci: fix rust-cache running before checkout in shard-snapshot job The `test-shard-snapshot-api-s3-minio` job ran `Swatinem/rust-cache` before `actions/checkout`, so there was no `Cargo.lock`/source present when the cache action ran. As a result the action no-opped and the job never actually restored or saved a Rust build cache. Move the cache step to run after checkout. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: remove dead rust-cache steps from docker-only jobs These jobs only build Docker images via `docker buildx`/docker build and never invoke cargo directly, so the `Swatinem/rust-cache` step never populates or restores anything useful: - integration-tests.yml: `test-consistency` (docker buildx + shell consistency checks only) - docker-image.yml: `build` and `build-gpu` (docker buildx only) Drop the unused cache steps. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: drop rust-cache from coverage and release workflows These workflows run on rare triggers (coverage: nightly schedule; release-artifacts: on release publish), so by the time they run again their cache is almost always already evicted from the 10 GB Actions cache budget. They mostly just consume cache space that would otherwise be useful to the frequently-run PR builds, so remove the rust-cache steps entirely: - coverage.yml: unit-coverage and integration-coverage - release-artifacts.yml: build-windows-binaries Co-authored-by: Cursor <cursoragent@cursor.com> * ci: drop explicit clippy cache key in rust-lint The lint job has no compatible cache peer to share with: clippy produces clippy-driver metadata that cargo fingerprints separately from normal build/test artifacts, and its `--all-features` invocation pulls in the GPU dependency crates, so it matches neither the rust-tests nor the gpu group. With nothing to share, the explicit `key: clippy` is equivalent to the default per-job key, so drop it for consistency with the rest of the workflows. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: dedicated rust-cache keys with single writer per group Give related jobs explicit cache keys and let only the broadest build in each group save the cache (`save-if: "false"` on the others), so a narrower build can't overwrite it with fewer compiled dependencies first. - `rust-tests` (rust.yml): explicit `shared-key: rust-tests`. It builds `--workspace --tests`, which pulls in dev-dependency features that the integration-tests builds (plain `cargo build`) do not, so it is kept as its own dependency cache rather than merged with integration-tests. - `integration-tests`: writer = integration-tests; readers = integration-tests-consensus, test-shard-snapshot-api-s3-minio. - `edge`: writer = edge-test (clippy + examples build); reader = edge-rust-check. Both build the amalgamated qdrant-edge `examples` package. rust-gpu keeps its own default cache (the `gpu` feature adds the ash/gpu-allocator/shaderc dependency crates). Co-authored-by: Cursor <cursoragent@cursor.com> * Reuse `integration-tests` build cache for `io-bridge-object-store-tests` workflow * Cleanup Docker cache in GHA workflows * ci: only save rust-cache on the integration branch Under the 10 GB Actions cache budget there's no practical benefit to saving feature-branch build caches: they'd be evicted before being reused. Scope every rust-cache *writer* to save only on `dev` (the branch PRs target and restore from) via `save-if`: - rust.yml, rust-lint.yml, edge-test.yml, integration-tests.yml Reader jobs already have `save-if: "false"` and are unchanged. Also drop rust-cache from rust-gpu.yml entirely: it only runs on `master` pushes (releases, a few times a month at most), so any cache would always be evicted between runs. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>