mirror of
https://github.com/qdrant/qdrant.git
synced 2026-08-07 02:20:55 -05:00
* Minor collection optimizer cleanup * Make optimizers better aware of available vs soft deleted points * Fix incorrect deleted state on proxy segment for double delete * Rename upsert_vector to upsert_point, because we work with points * Refactor point methods for more clear and consistent naming * Replace internal_size in IdTracker with total_point_count * Keep track of vector deletion count on storage creation * Add sparse index optimizer, to optimize indexes with high deletion count * Add minimum vector count threshold to sparse index optimizer * Add sparse index optimizer test * Use consistent naming, write vector in full everywhere * Simplify vacuum optimizer a bit * Merge sparse index optimizer into vacuum optimizer * Improve update_from in segment builder by returning early * More accurately count vectors in segment optimizer * Remove random from vacuum optimizer tests to make them more reliable * Don't expose the total points in segment info, use available points * Process review feedback * Compare available vectors against indexed ones in vacuum optimizer This is much better than using the number of soft-deleted vectors when the segment was created for calculations. Not to mention that value had other problems as well. * Remove create_deleted_vector_count field, update vacuum test parameters * Potentially solve out of bound panic when building index * Review fixes: - Propagate deleted flags into payload hnsw building - Use `total` number of points for building HNSW instead of number of available points - minor refactoring of `hnsw_config` copy -> clone - Better detection of `indexed_points` in HNSW * fix assert condition * Optional named vectors optimizer reveiw 2 (#1794) * review with Ivan * fmt * remove available_vector_count from segment entry * remove total_point_count from segment entry --------- Co-authored-by: Ivan Pleshkov <pleshkov.ivan@gmail.com> * rollback changes in deleted count in proxy segment * improve vector threshold detection logic in optimized_segment_builder * style changes * fix propagate deleted points to vectors * Fix typo in method name --------- Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com> Co-authored-by: Ivan Pleshkov <pleshkov.ivan@gmail.com>
147 lines
4.9 KiB
Rust
147 lines
4.9 KiB
Rust
mod fixtures;
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use std::collections::HashMap;
|
|
use std::sync::atomic::{AtomicBool, Ordering};
|
|
use std::sync::Arc;
|
|
use std::time::{Duration, Instant};
|
|
|
|
use itertools::Itertools;
|
|
use segment::data_types::vectors::{only_default_vector, DEFAULT_VECTOR_NAME};
|
|
use segment::entry::entry_point::{OperationError, SegmentEntry};
|
|
use segment::segment::Segment;
|
|
use segment::segment_constructor::segment_builder::SegmentBuilder;
|
|
use segment::types::{Indexes, SegmentConfig, VectorDataConfig};
|
|
use tempfile::Builder;
|
|
|
|
use crate::fixtures::segment::{build_segment_1, build_segment_2, empty_segment};
|
|
|
|
#[test]
|
|
fn test_building_new_segment() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
let temp_dir = Builder::new().prefix("segment_temp_dir").tempdir().unwrap();
|
|
|
|
let stopped = AtomicBool::new(false);
|
|
|
|
// let segment1_dir = dir.path().join("segment_1");
|
|
// let segment2_dir = dir.path().join("segment_2");
|
|
|
|
let segment1 = build_segment_1(dir.path());
|
|
let mut segment2 = build_segment_2(dir.path());
|
|
|
|
let mut builder =
|
|
SegmentBuilder::new(dir.path(), temp_dir.path(), &segment1.segment_config).unwrap();
|
|
|
|
// Include overlapping with segment1 to check the
|
|
segment2
|
|
.upsert_point(100, 3.into(), &only_default_vector(&[0., 0., 0., 0.]))
|
|
.unwrap();
|
|
|
|
builder.update_from(&segment1, &stopped).unwrap();
|
|
builder.update_from(&segment2, &stopped).unwrap();
|
|
builder.update_from(&segment2, &stopped).unwrap();
|
|
|
|
// Check what happens if segment building fails here
|
|
|
|
let segment_count = dir.path().read_dir().unwrap().count();
|
|
|
|
assert_eq!(segment_count, 2);
|
|
|
|
let temp_segment_count = temp_dir.path().read_dir().unwrap().count();
|
|
|
|
assert_eq!(temp_segment_count, 1);
|
|
|
|
// Now we finalize building
|
|
|
|
let merged_segment: Segment = builder.build(&stopped).unwrap();
|
|
|
|
let new_segment_count = dir.path().read_dir().unwrap().count();
|
|
|
|
assert_eq!(new_segment_count, 3);
|
|
|
|
assert_eq!(
|
|
merged_segment.iter_points().count(),
|
|
merged_segment.available_point_count(),
|
|
);
|
|
assert_eq!(
|
|
merged_segment.available_point_count(),
|
|
segment1
|
|
.iter_points()
|
|
.chain(segment2.iter_points())
|
|
.unique()
|
|
.count(),
|
|
);
|
|
|
|
assert_eq!(merged_segment.point_version(3.into()), Some(100));
|
|
}
|
|
|
|
fn estimate_build_time(segment: &Segment, stop_timeout_millis: u64) -> (u64, bool) {
|
|
let stopped = Arc::new(AtomicBool::new(false));
|
|
|
|
let dir = Builder::new().prefix("segment_dir1").tempdir().unwrap();
|
|
let temp_dir = Builder::new().prefix("segment_temp_dir").tempdir().unwrap();
|
|
|
|
let segment_config = SegmentConfig {
|
|
vector_data: HashMap::from([(
|
|
DEFAULT_VECTOR_NAME.to_owned(),
|
|
VectorDataConfig {
|
|
size: segment.segment_config.vector_data[DEFAULT_VECTOR_NAME].size,
|
|
distance: segment.segment_config.vector_data[DEFAULT_VECTOR_NAME].distance,
|
|
hnsw_config: None,
|
|
quantization_config: None,
|
|
},
|
|
)]),
|
|
index: Indexes::Hnsw(Default::default()),
|
|
..Default::default()
|
|
};
|
|
|
|
let mut builder =
|
|
SegmentBuilder::new(dir.path(), temp_dir.path(), &segment_config).unwrap();
|
|
|
|
builder.update_from(segment, &stopped).unwrap();
|
|
|
|
let now = Instant::now();
|
|
|
|
let stopped_t = stopped.clone();
|
|
|
|
std::thread::Builder::new()
|
|
.name("build_estimator_timeout".to_string())
|
|
.spawn(move || {
|
|
std::thread::sleep(Duration::from_millis(stop_timeout_millis));
|
|
stopped_t.store(true, Ordering::Release);
|
|
})
|
|
.unwrap();
|
|
|
|
let res = builder.build(&stopped);
|
|
|
|
let is_cancelled = match res {
|
|
Ok(_) => false,
|
|
Err(err) => matches!(err, OperationError::Cancelled { .. }),
|
|
};
|
|
|
|
(now.elapsed().as_millis() as u64, is_cancelled)
|
|
}
|
|
|
|
#[test]
|
|
fn test_building_cancellation() {
|
|
let dir = Builder::new().prefix("segment_dir").tempdir().unwrap();
|
|
|
|
let mut segment = empty_segment(dir.path());
|
|
|
|
for idx in 0..1000 {
|
|
segment
|
|
.upsert_point(1, idx.into(), &only_default_vector(&[0., 0., 0., 0.]))
|
|
.unwrap();
|
|
}
|
|
|
|
// Checks that optimization with longed cancellation timeout will also finishes fast
|
|
let (time_fast, is_stopped_fast) = estimate_build_time(&segment, 20);
|
|
let (time_long, _is_stopped_long) = estimate_build_time(&segment, 200);
|
|
|
|
assert!(is_stopped_fast);
|
|
|
|
assert!(time_fast < time_long);
|
|
}
|
|
}
|