Remove unecesssary Clippy allows (#9267)

2026-07-23 11:11:00 -05:00 · 2026-06-02 16:54:27 +02:00
parent 2365d1a3ef
commit 0e2ed93172
34 changed files with 1 additions and 41 deletions
--- a/lib/collection/src/shards/replica_set/read_ops.rs
+++ b/lib/collection/src/shards/replica_set/read_ops.rs
@@ -17,7 +17,6 @@ use crate::operations::types::*;
 use crate::operations::universal_query::shard_query::{ShardQueryRequest, ShardQueryResponse};

 impl ShardReplicaSet {
-    #[allow(clippy::too_many_arguments)]
    pub async fn scroll_by(
        &self,
        request: Arc<ScrollRequestInternal>,
--- a/lib/collection/src/shards/transfer/wal_delta.rs
+++ b/lib/collection/src/shards/transfer/wal_delta.rs
@@ -70,7 +70,6 @@ use crate::shards::shard_holder::SharedShardHolder;
 ///
 /// If cancelled - the remote shard may only be partially recovered/transferred and the local shard
 /// may be left in an unexpected state. This must be resolved manually in case of cancellation.
-#[allow(clippy::too_many_arguments)]
 pub(super) async fn transfer_wal_delta(
    transfer_config: ShardTransfer,
    shard_holder: SharedShardHolder,
--- a/lib/collection/src/update_handler.rs
+++ b/lib/collection/src/update_handler.rs
@@ -51,7 +51,6 @@ pub struct OperationData {

 /// Signal, used to inform Updater process
 #[derive(Debug)]
-#[allow(clippy::large_enum_variant)]
 pub enum UpdateSignal {
    /// Requested operation to perform
    Operation(OperationData),
--- a/lib/collection/src/update_workers/flush_workers.rs
+++ b/lib/collection/src/update_workers/flush_workers.rs
@@ -29,7 +29,6 @@ impl UpdateWorkers {
        })
    }

-    #[allow(clippy::too_many_arguments)]
    fn flush_worker_internal(
        segments: LockedSegmentHolder,
        wal: LockedWal,
@@ -99,7 +98,6 @@ impl UpdateWorkers {
        }
    }

-    #[allow(clippy::too_many_arguments)]
    pub async fn flush_worker_fn(
        segments: LockedSegmentHolder,
        wal: LockedWal,
--- a/lib/quantization/src/encoded_vectors_binary.rs
+++ b/lib/quantization/src/encoded_vectors_binary.rs
@@ -1077,7 +1077,6 @@ unsafe extern "C" {
    ) -> u32;
 }

-#[allow(missing_docs)]
 #[cfg(target_arch = "x86_64")]
 #[target_feature(enable = "avx512vl")]
 #[target_feature(enable = "avx512vpopcntdq")]
--- a/lib/segment/src/id_tracker/id_tracker_base/read_only_tracker_enum.rs
+++ b/lib/segment/src/id_tracker/id_tracker_base/read_only_tracker_enum.rs
@@ -7,7 +7,6 @@ use crate::id_tracker::mutable_id_tracker::read_only::ReadOnlyAppendableIdTracke
 use crate::id_tracker::{IdTrackerRead, PointMappingsRefEnum};
 use crate::types::{PointIdType, SeqNumberType};

-#[allow(clippy::large_enum_variant)]
 pub enum ReadOnlyIdTrackerEnum<S: UniversalRead> {
    Appendable(ReadOnlyAppendableIdTracker),
    Immutable(ReadOnlyImmutableIdTracker<S>),
--- a/lib/segment/src/id_tracker/id_tracker_base/tracker_enum.rs
+++ b/lib/segment/src/id_tracker/id_tracker_base/tracker_enum.rs
@@ -14,7 +14,6 @@ use crate::id_tracker::mutable_id_tracker::MutableIdTracker;
 use crate::types::{PointIdType, SeqNumberType};

 #[derive(Debug)]
-#[allow(clippy::large_enum_variant)]
 pub enum IdTrackerEnum {
    MutableIdTracker(MutableIdTracker),
    ImmutableIdTracker(ImmutableIdTracker<MmapFile>),
--- a/lib/segment/src/index/field_index/bool_index/read_only_bool_index/mod.rs
+++ b/lib/segment/src/index/field_index/bool_index/read_only_bool_index/mod.rs
@@ -22,7 +22,6 @@ mod read_ops;
 /// [3]: common::universal_io::UniversalRead
 /// [4]: super::read_ops::BoolIndexRead
 pub struct ReadOnlyBoolIndex {
-    #[allow(dead_code)]
    pub(super) _base_dir: PathBuf,
    pub(super) storage: ReadOnlyStorage,
    pub(super) indexed_count: usize,
--- a/lib/segment/src/index/field_index/full_text_index/mutable_text_index/read_only/mod.rs
+++ b/lib/segment/src/index/field_index/full_text_index/mutable_text_index/read_only/mod.rs
@@ -15,7 +15,6 @@ mod read_ops;
 ///
 /// Loading / lifecycle (constructor, `files`, `populate`, `clear_cache`, …)
 /// will be added in a follow-up; until then the type is not yet constructed.
-#[allow(dead_code)]
 pub struct ReadOnlyAppendableFullTextIndex<S: UniversalRead> {
    pub(super) inner: MutableFullTextIndexInner,
    // Read once the lifecycle layer lands; until then the field is held to
--- a/lib/segment/src/index/field_index/index_selector.rs
+++ b/lib/segment/src/index/field_index/index_selector.rs
@@ -49,7 +49,6 @@ pub struct IndexSelectorGridstore<'a> {

 impl IndexSelector<'_> {
    /// Loads the correct index based on `index_type`.
-    #[allow(clippy::too_many_arguments)]
    pub fn new_index_with_type(
        &self,
        field: &JsonPath,
--- a/lib/segment/src/index/field_index/map_index/immutable_map_index/lifecycle.rs
+++ b/lib/segment/src/index/field_index/map_index/immutable_map_index/lifecycle.rs
@@ -187,7 +187,6 @@ where
                deleted_value_to_points_container.resize(pos + 1, false);
            }

-            #[allow(unused_variables)]
            let did_exist = !deleted_value_to_points_container.replace(pos, true);
            debug_assert!(did_exist, "value {value} was already deleted");
        }
--- a/lib/segment/src/index/field_index/null_index/read_only_null_index/mod.rs
+++ b/lib/segment/src/index/field_index/null_index/read_only_null_index/mod.rs
@@ -21,7 +21,6 @@ mod read_ops;
 /// [3]: common::universal_io::UniversalRead
 /// [4]: super::read_ops::NullIndexRead
 pub struct ReadOnlyNullIndex {
-    #[allow(dead_code)]
    pub(super) _base_dir: PathBuf,
    pub(super) storage: ReadOnlyStorage,
    pub(super) total_point_count: usize,
--- a/lib/segment/src/index/hnsw_index/gpu/gpu_insert_context.rs
+++ b/lib/segment/src/index/hnsw_index/gpu/gpu_insert_context.rs
@@ -96,7 +96,6 @@ impl ShaderBuilderParameters for GpuInsertResources {
 }

 impl GpuInsertResources {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        gpu_vector_storage: &GpuVectorStorage,
        groups_count: usize,
@@ -180,7 +179,6 @@ impl GpuInsertResources {
 }

 impl<'a> GpuInsertContext<'a> {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        gpu_vector_storage: &'a GpuVectorStorage,
        // Parallel inserts count.
--- a/lib/segment/src/index/hnsw_index/hnsw/gpu_build.rs
+++ b/lib/segment/src/index/hnsw_index/hnsw/gpu_build.rs
@@ -106,7 +106,6 @@ pub(super) fn build_filtered_graph_on_gpu(
    )
 }

-#[allow(clippy::too_many_arguments)]
 fn build_graph_on_gpu<'a, 'b>(
    gpu_insert_context: Option<&mut GpuInsertContext<'b>>,
    graph_layers_builder: &GraphLayersBuilder,
--- a/lib/segment/src/index/hnsw_index/hnsw/search.rs
+++ b/lib/segment/src/index/hnsw_index/hnsw/search.rs
@@ -22,7 +22,6 @@ use crate::vector_storage::query::DiscoverQuery;
 use crate::vector_storage::{VectorStorageEnum, VectorStorageRead, new_raw_scorer};

 impl HNSWIndex {
-    #[allow(clippy::too_many_arguments)]
    pub(super) fn search_with_graph(
        &self,
        vector: &QueryVector,
--- a/lib/segment/src/index/struct_payload_index/mod.rs
+++ b/lib/segment/src/index/struct_payload_index/mod.rs
@@ -32,7 +32,6 @@ use crate::types::{PayloadFieldSchema, PayloadKeyType, VectorNameBuf};
 use crate::vector_storage::VectorStorageEnum;

 #[derive(Debug)]
-#[allow(clippy::enum_variant_names)]
 enum StorageType {
    GridstoreAppendable,
    GridstoreNonAppendable,
--- a/lib/segment/src/payload_storage/mod.rs
+++ b/lib/segment/src/payload_storage/mod.rs
@@ -8,7 +8,6 @@ pub mod mmap_payload_storage;
 mod payload_storage_base;
 pub mod payload_storage_enum;
 pub mod query_checker;
-#[allow(dead_code)]
 pub mod read_only;
 #[cfg(test)]
 mod tests;
--- a/lib/segment/src/segment/read_view/mod.rs
+++ b/lib/segment/src/segment/read_view/mod.rs
@@ -28,7 +28,6 @@ use crate::vector_storage::VectorStorageEnum;
 ///
 /// The motivation for this is to unify the read code between
 /// regular `Segment` and `ReadOnlySegment`.
-#[allow(unused, dead_code)]
 pub struct SegmentReadView<'s, TIdTracker, TPayloadIndex, TPayloadStorage, TVectorData>
 where
    TIdTracker: IdTrackerRead,
@@ -61,7 +60,6 @@ pub type SegmentReadViewFor<'s> = SegmentReadView<
    VectorData,
 >;

-#[allow(unused, dead_code)]
 impl<'s, TIdT, TPI, TPS, TVD> SegmentReadView<'s, TIdT, TPI, TPS, TVD>
 where
    TIdT: IdTrackerRead,
--- a/lib/segment/src/segment/segment_ops.rs
+++ b/lib/segment/src/segment/segment_ops.rs
@@ -75,7 +75,6 @@ impl Segment {
    /// # Warning
    ///
    /// Available for appendable segments only.
-    #[allow(clippy::needless_pass_by_ref_mut)] // ensure single access to AtomicRefCell vector_index
    pub(super) fn update_vectors(
        &mut self,
        internal_id: PointOffsetType,
--- a/lib/segment/src/vector_storage/chunked_vectors/mod.rs
+++ b/lib/segment/src/vector_storage/chunked_vectors/mod.rs
@@ -3,7 +3,6 @@ mod config;
 mod read;
 mod write;

-#[allow(unused_imports)]
 pub use read::ChunkedVectorsRead;
 pub use write::ChunkedVectors;

--- a/lib/segment/src/vector_storage/chunked_vectors/read.rs
+++ b/lib/segment/src/vector_storage/chunked_vectors/read.rs
@@ -295,7 +295,6 @@ impl<T: bytemuck::Pod + Send, S: UniversalRead> ChunkedVectorsRead<T, S> {
    }
 }

-#[allow(dead_code)] // pending: read-only vector storage enum will use this
 fn read_status_len(status_file: &Path) -> OperationResult<usize> {
    let bytes = fs::read(status_file)?;
    let needed = std::mem::size_of::<usize>();
--- a/lib/segment/src/vector_storage/mod.rs
+++ b/lib/segment/src/vector_storage/mod.rs
@@ -8,7 +8,6 @@ pub mod quantized;
 pub mod query;
 pub mod query_scorer;
 pub mod raw_scorer;
-#[allow(dead_code)]
 pub mod read_only;
 pub mod sparse;
 mod vector_storage_base;
--- a/lib/segment/src/vector_storage/quantized/quantized_scorer_builder.rs
+++ b/lib/segment/src/vector_storage/quantized/quantized_scorer_builder.rs
@@ -34,7 +34,6 @@ pub(super) struct QuantizedScorerBuilder<'a> {
 }

 impl<'a> QuantizedScorerBuilder<'a> {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        quantized_storage: &'a QuantizedVectorStorage,
        quantization_config: &'a QuantizationConfig,
--- a/lib/segment/tests/integration/hnsw_quantized_search_test.rs
+++ b/lib/segment/tests/integration/hnsw_quantized_search_test.rs
@@ -801,7 +801,7 @@ fn hnsw_quantized_low_bit_compare_test(

 /// Caller must keep the returned tempdirs alive for as long as the segment
 /// and HNSW index are used.
-#[allow(clippy::type_complexity, clippy::too_many_arguments)]
+#[allow(clippy::too_many_arguments)]
 fn build_quantized_hnsw_for_compare(
    vectors: &[Vec<f32>],
    distance: Distance,
--- a/lib/shard/src/optimizers/config_mismatch_optimizer.rs
+++ b/lib/shard/src/optimizers/config_mismatch_optimizer.rs
@@ -29,7 +29,6 @@ pub struct ConfigMismatchOptimizer {
 }

 impl ConfigMismatchOptimizer {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        thresholds_config: OptimizerThresholds,
        segments_path: PathBuf,
--- a/lib/shard/src/optimizers/indexing_optimizer.rs
+++ b/lib/shard/src/optimizers/indexing_optimizer.rs
@@ -31,7 +31,6 @@ pub struct IndexingOptimizer {
 }

 impl IndexingOptimizer {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        default_segments_number: usize,
        thresholds_config: OptimizerThresholds,
--- a/lib/shard/src/optimizers/merge_optimizer.rs
+++ b/lib/shard/src/optimizers/merge_optimizer.rs
@@ -52,7 +52,6 @@ pub struct MergeOptimizer {
 }

 impl MergeOptimizer {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        default_segments_number: usize,
        thresholds_config: OptimizerThresholds,
--- a/lib/shard/src/optimizers/vacuum_optimizer.rs
+++ b/lib/shard/src/optimizers/vacuum_optimizer.rs
@@ -33,7 +33,6 @@ pub struct VacuumOptimizer {
 }

 impl VacuumOptimizer {
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        deleted_threshold: f64,
        min_vectors_number: usize,
--- a/lib/shard/src/proxy_segment/mod.rs
+++ b/lib/shard/src/proxy_segment/mod.rs
@@ -215,7 +215,6 @@ impl ProxySegment {
        filter: Option<Cow<'_, Filter>>,
        deleted_points: impl IntoIterator<Item = PointIdType>,
    ) -> Filter {
-        #[allow(clippy::from_iter_instead_of_collect)]
        let wrapper_condition = Condition::HasId(HasIdCondition::from_iter(deleted_points));
        match filter {
            None => Filter::new_must_not(wrapper_condition),
--- a/lib/storage/src/content_manager/consensus/consensus_wal.rs
+++ b/lib/storage/src/content_manager/consensus/consensus_wal.rs
@@ -194,7 +194,6 @@ impl ConsensusOpWal {

                // Check that new entry index is sequential (it's not greater than next WAL index),
                // or truncate entries at the tail of WAL, if it overwrites some
-                #[allow(clippy::comparison_chain)] // stupid ahh diagnostics 🙄
                if new_entry_wal_index > next_wal_index {
                    return Err(StorageError::service_error(format!(
                        "Can't append entry with Raft index {} (expected WAL index {}), \
--- a/lib/storage/src/content_manager/toc/mod.rs
+++ b/lib/storage/src/content_manager/toc/mod.rs
@@ -110,7 +110,6 @@ pub struct TableOfContent {

 impl TableOfContent {
    /// PeerId does not change during execution so it is ok to copy it here.
-    #[allow(clippy::too_many_arguments)]
    pub fn new(
        storage_config: &StorageConfig,
        optimizer_resource_budget: ResourceBudget,
--- a/src/actix/api/query_api.rs
+++ b/src/actix/api/query_api.rs
@@ -28,7 +28,6 @@ use crate::settings::ServiceConfig;
 pub const THIS_FILE: &str = file!();

 #[post("/collections/{collection_name}/points/query")]
-#[allow(clippy::too_many_arguments)]
 async fn query_points(
    dispatcher: web::Data<Dispatcher>,
    collection: Path<CollectionPath>,
@@ -106,7 +105,6 @@ async fn query_points(
    )
 }

-#[allow(clippy::too_many_arguments)]
 #[post("/collections/{collection_name}/points/query/batch")]
 async fn query_points_batch(
    dispatcher: web::Data<Dispatcher>,
@@ -195,7 +193,6 @@ async fn query_points_batch(
    )
 }

-#[allow(clippy::too_many_arguments)]
 #[post("/collections/{collection_name}/points/query/groups")]
 async fn query_points_groups(
    dispatcher: web::Data<Dispatcher>,
--- a/src/actix/api/update_api.rs
+++ b/src/actix/api/update_api.rs
@@ -30,7 +30,6 @@ struct FieldPath {
 }

 #[put("/collections/{collection_name}/points")]
-#[allow(clippy::too_many_arguments)]
 async fn upsert_points(
    dispatcher: web::Data<Dispatcher>,
    collection: Path<CollectionPath>,
@@ -111,7 +110,6 @@ async fn delete_points(
 }

 #[put("/collections/{collection_name}/points/vectors")]
-#[allow(clippy::too_many_arguments)]
 async fn update_vectors(
    dispatcher: web::Data<Dispatcher>,
    collection: Path<CollectionPath>,
@@ -323,7 +321,6 @@ async fn clear_payload(
    process_response(res, timing, request_hw_counter.to_rest_api())
 }

-#[allow(clippy::too_many_arguments)]
 #[post("/collections/{collection_name}/points/batch")]
 async fn update_batch(
    dispatcher: web::Data<Dispatcher>,
--- a/src/common/query.rs
+++ b/src/common/query.rs
@@ -295,7 +295,6 @@ pub async fn do_query_points(
        .ok_or_else(|| StorageError::service_error("Empty query result"))
 }

-#[allow(clippy::too_many_arguments)]
 pub async fn do_query_batch_points(
    toc: &TableOfContent,
    collection_name: &str,