upstream-archive/qdrant
1
0
Fork 0
mirror of https://github.com/qdrant/qdrant.git synced 2026-08-05 17:40:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't update payload if point was not upserted (#1564)

Browse Source 
* fix values count loading in geoindex

* don't update payload if point was not upserted

* remove debug comments

* post-check of internal id

* revert changes from geo indexing branch
This commit is contained in:
Ivan Pleshkov
2023-03-15 13:36:46 +04:00
committed by GitHub
parent 30ef3b6ea8
commit 7fd15ef4af
1 changed files with 45 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
lib/segment/src/segment.rs
View File

@@ -719,13 +719,18 @@ impl SegmentEntry for Segment {
point_id: PointIdType,
full_payload: &Payload,
) -> OperationResult<bool> {
let internal_id = self.lookup_internal_id(point_id)?;
self.handle_version_and_failure(op_num, Some(internal_id), |segment| {
segment
.payload_index
.borrow_mut()
.assign_all(internal_id, full_payload)?;
Ok((true, Some(internal_id)))
let internal_id = self.id_tracker.borrow().internal_id(point_id);
self.handle_version_and_failure(op_num, internal_id, |segment| match internal_id {
Some(internal_id) => {
segment
.payload_index
.borrow_mut()
.assign_all(internal_id, full_payload)?;
Ok((true, Some(internal_id)))
}
None => Err(OperationError::PointIdError {
missed_point_id: point_id,
}),
})
}
@@ -735,13 +740,18 @@ impl SegmentEntry for Segment {
point_id: PointIdType,
payload: &Payload,
) -> OperationResult<bool> {
let internal_id = self.lookup_internal_id(point_id)?;
self.handle_version_and_failure(op_num, Some(internal_id), |segment| {
segment
.payload_index
.borrow_mut()
.assign(internal_id, payload)?;
Ok((true, Some(internal_id)))
let internal_id = self.id_tracker.borrow().internal_id(point_id);
self.handle_version_and_failure(op_num, internal_id, |segment| match internal_id {
Some(internal_id) => {
segment
.payload_index
.borrow_mut()
.assign(internal_id, payload)?;
Ok((true, Some(internal_id)))
}
None => Err(OperationError::PointIdError {
missed_point_id: point_id,
}),
})
}
@@ -751,13 +761,18 @@ impl SegmentEntry for Segment {
point_id: PointIdType,
key: PayloadKeyTypeRef,
) -> OperationResult<bool> {
let internal_id = self.lookup_internal_id(point_id)?;
self.handle_version_and_failure(op_num, Some(internal_id), |segment| {
segment
.payload_index
.borrow_mut()
.delete(internal_id, key)?;
Ok((true, Some(internal_id)))
let internal_id = self.id_tracker.borrow().internal_id(point_id);
self.handle_version_and_failure(op_num, internal_id, |segment| match internal_id {
Some(internal_id) => {
segment
.payload_index
.borrow_mut()
.delete(internal_id, key)?;
Ok((true, Some(internal_id)))
}
None => Err(OperationError::PointIdError {
missed_point_id: point_id,
}),
})
}
@@ -766,10 +781,15 @@ impl SegmentEntry for Segment {
op_num: SeqNumberType,
point_id: PointIdType,
) -> OperationResult<bool> {
let internal_id = self.lookup_internal_id(point_id)?;
self.handle_version_and_failure(op_num, Some(internal_id), |segment| {
segment.payload_index.borrow_mut().drop(internal_id)?;
Ok((true, Some(internal_id)))
let internal_id = self.id_tracker.borrow().internal_id(point_id);
self.handle_version_and_failure(op_num, internal_id, |segment| match internal_id {
Some(internal_id) => {
segment.payload_index.borrow_mut().drop(internal_id)?;
Ok((true, Some(internal_id)))
}
None => Err(OperationError::PointIdError {
missed_point_id: point_id,
}),
})
}