upstream-archive/qdrant
1
0
Fork 0
mirror of https://github.com/qdrant/qdrant.git synced 2026-09-29 09:27:53 -05:00
Code Issues Packages Projects Releases Wiki Activity

After payload index migration, delete RocksDB files (#6873)

Browse Source 
* After payload index migration, delete RocksDB files

* Add comment on why it is safe to not clean up RocksDB files in some cases

* Update lib/segment/src/index/struct_payload_index.rs

Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>

* Reformat

---------

Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
This commit is contained in:
Tim Visée
2025-07-17 14:00:42 +02:00
committed by generall
co-authored by Roman Titov
parent b110600233
commit a2188f928f
1 changed files with 37 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/segment/src/index/struct_payload_index.rs
+37
View File
@@ -390,6 +390,43 @@ impl StructPayloadIndex {
index.load_all_fields(create)?;
// If we have a RocksDB instance, but no more index using it, completely delete it here
#[cfg(feature = "rocksdb")]
if !index.config.indices.any_is_rocksdb()
&& let Some(db) = index.db.take()
{
match Arc::try_unwrap(db) {
Ok(db) => {
log::trace!(
"Deleting RocksDB for payload indices, no payload index uses it anymore"
);
// Close RocksDB instance
let db = db.into_inner();
drop(db);
// Destroy all RocksDB files
let options = crate::common::rocksdb_wrapper::make_db_options();
match rocksdb::DB::destroy(&options, &index.path) {
Ok(_) => log::debug!("Deleted RocksDB for payload indices"),
Err(err) => {
log::warn!("Failed to delete RocksDB for payload indices: {err}")
}
}
}
// Here we don't have exclusive ownership of RocksDB, which prevents us from
// controlling and closing the instance. Because of it, we cannot destroy the
// RocksDB files, and leave them behind. We don't consider this a problem, because
// a future optimization run will get rid of these files.
Err(db) => {
log::warn!(
"RocksDB for payload indices could not be deleted, does not have exclusive ownership"
);
index.db.replace(db);
}
}
}
Ok(index)
}