Files
qdrant/tests/openapi/test_group.py
Andrey Vasnetsov 8a7325ad5d Remove deprecated search endpoints from OpenAPI, deprecate them in gRPC (#9982)
* Remove deprecated search/recommend/discover endpoints from OpenAPI

Remove deprecated REST API endpoint definitions from the OpenAPI
generator. These endpoints were deprecated in v1.13.3 (`f4ced2567`,
#5907, 2025-01-30) in favor of the universal `/points/query` endpoint:

- POST /points/search
- POST /points/search/batch
- POST /points/search/groups
- POST /points/recommend
- POST /points/recommend/batch
- POST /points/recommend/groups
- POST /points/discover
- POST /points/discover/batch

Also removes the corresponding request types from the schema generator
and updates the expected API count in the consistency check.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Migrate OpenAPI integration tests to /points/query

The deprecated /points/search, /points/recommend and /points/discover
endpoints (along with their /batch and /groups variants) were removed
from the OpenAPI spec, which caused validation failures in the Python
integration test harness.

This commit migrates the affected tests to the universal /points/query
endpoint:

- Delete tests dedicated to the deprecated endpoints:
  test_recommend.py, test_discover.py, test_multicollection_reco.py,
  test_recommendation_multivector.py
- Refactor remaining tests to call /points/query (and /query/batch,
  /query/groups), translating request bodies (vector -> query / using,
  positive/negative -> query.recommend, target/context -> query.discover)
  and unwrapping the new result.points response shape.
- Drop equivalence assertions against the now-removed legacy endpoints.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Relax non-empty assertions in migrated recommend/discover tests

The previous migration added `len(...) > 0` assertions to tests that
previously only checked equivalence between the deprecated and new
API. These assertions are too strict because the parametrized
`query_filter` cases legitimately produce empty result sets.

Drop the `> 0` assertion and rely on `request_with_validation` to
verify the response is well-formed and HTTP OK.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Migrate remaining OpenAPI tests off deprecated search endpoints

Tests added to dev after the original migration was written still call
/points/search and /points/recommend/groups through
`request_with_validation`, which resolves the endpoint against the
OpenAPI spec and therefore breaks once the endpoint is not in the spec:

- test_turbo4_storage.py, test_sparse_idf_corpus.py, test_validation.py:
  translate /points/search to /points/query (vector{name,vector} ->
  query + using, result -> result.points).
- test_group.py: drop the /points/recommend/groups half of the
  lookup_from validation test in favour of the query equivalent.

test_sparse_idf_corpus.py's test_query_api_supports_idf_corpus goes
away: with the helper on /points/query every test in the file now
exercises what it asserted.

Also record why test_recommend_group cannot assert on its groups: it
uses every point in the collection as a recommend example, so all of
them are excluded and the result is legitimately empty.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Regenerate openapi.json without the deprecated search endpoints

Drops the 8 deprecated paths and the request schemas that only they
referenced: Search/Recommend/Discover request (+Batch, +Groups) types
and their exclusive dependencies (NamedVector, NamedSparseVector,
NamedVectorStruct, UsingVector, RecommendExample, ContextExamplePair).

Regenerated output is a strict subset of the previous spec, and every
remaining $ref still resolves.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Deprecate the search/recommend/discover RPCs in gRPC

The REST counterparts have carried `deprecated: true` since v1.13.3 and
are now gone from the OpenAPI spec, while the gRPC RPCs never got any
deprecation annotation at all. Mark all 8 with `option deprecated = true`
so generated clients warn, and point each doc comment at its `Query`
replacement.

tonic puts `#[deprecated]` on the generated client methods only; the
server trait gets the doc comment alone, so our own `impl` is unaffected.
The RPCs keep serving traffic — this is annotation only.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Restore the deleted recommend/discover suites on /points/query

The earlier migration deleted these four files outright, but the
query-side tests it left behind are all shallow smoke tests
(`len(result) > 0`, `"points" in result[0]`). The deleted ones carried
invariants with no query-API equivalent anywhere, so deleting them was a
real loss of coverage rather than de-duplication:

- test_recommend.py: default strategy equals average_vector; batch
  results identical to sequential singles across six request shapes;
  best_score with only negatives yields all-negative scores; best_score
  with a single positive orders identically to a nearest query; raw
  vectors as examples equal ids as examples.
- test_discover.py: context-only scores are all <= 0; target-only orders
  identically to a nearest query but scores differently; with a fixed
  context the integer part of the score is stable while the decimal part
  moves, and vice versa with a fixed target; batch equals singles;
  lookup_from by id equals by vector.
- test_multicollection_reco.py: cross-collection lookup_from, plus
  wrong-vector-size, unknown-collection and unknown-vector rejections.
- test_recommendation_multivector.py: the same recommend invariants over
  a max_sim multivector collection, which the query suite never covered.

Only test_recommend_missing_lookup_from_collection_with_raw_vector is
dropped as genuinely redundant — test_query.py's
test_query_missing_lookup_from_collection covers query, query/batch and
prefetch.

Two request-shape differences the translation had to absorb:

- Giving no examples at all is 422 (a RecommendInput validation rule),
  where the legacy API reported 400 from the query itself. A malformed
  example, such as an empty vector, is still 400.
- DiscoverInput requires the `context` key and accepts only an explicit
  null to mean "no context", so target-only discover must spell it out.
  The legacy API let it be omitted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-07-27 18:09:43 +02:00

554 lines
17 KiB
Python

import pytest
import jsons
from pytest_cases import parametrize, fixture_ref
from .helpers.collection_setup import basic_collection_setup, drop_collection
from .helpers.helpers import request_with_validation
@pytest.fixture(scope='module', autouse=True)
def lookup_collection_name(collection_name) -> str:
return f"{collection_name}_lookup"
@pytest.fixture(scope='module', autouse=True)
def set_serializer(lookup_collection_name):
def custom_serializer(obj: fixture_ref, **kwargs) -> str:
return lookup_collection_name
jsons.set_serializer(custom_serializer, fixture_ref)
def upsert_chunked_docs(collection_name, docs=50, chunks=5):
points = []
for doc in range(docs):
for chunk in range(chunks):
doc_id = doc
i = doc * chunks + chunk
p = {"id": i, "vector": [1.0, 0.0, 0.0, 0.0], "payload": {"docId": doc_id}}
points.append(p)
response = request_with_validation(
api="/collections/{collection_name}/points",
method="PUT",
path_params={"collection_name": collection_name},
query_params={"wait": "true"},
body={"points": points},
)
assert response.ok
def upsert_points_with_array_fields(collection_name, docs=3, chunks=5, id_offset=5000):
points = []
for doc in range(docs):
for chunk in range(chunks):
doc_ids = [f"valid_{doc}", f"valid_too_{doc}"]
i = doc * chunks + chunk + id_offset
p = {
"id": i,
"vector": [0.0, 1.0, 0.0, 0.0],
"payload": {"multiId": doc_ids},
}
points.append(p)
response = request_with_validation(
api="/collections/{collection_name}/points",
method="PUT",
path_params={"collection_name": collection_name},
query_params={"wait": "true"},
body={"points": points},
)
assert response.ok
def upsert_with_heterogenous_fields(collection_name):
points = [
{"id": 6000, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": "string"}}, # ok -> string
{"id": 6001, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": 123}}, # ok -> 123
{"id": 6002, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": [1, 2, 3]}}, # ok -> 1
{"id": 6003, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": ["a", "b", "c"]}}, # ok -> "a"
{"id": 6004, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": 2.42}}, # ok -> "2.42"
{"id": 6005, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": [["a", "b", "c"]]}}, # invalid
{"id": 6006, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": {"object": "string"}}}, # invalid
{"id": 6007, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": []}}, # invalid
{"id": 6008, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"heterogenousId": None}}, # invalid
]
response = request_with_validation(
api="/collections/{collection_name}/points",
method="PUT",
path_params={"collection_name": collection_name},
query_params={"wait": "true"},
body={"points": points},
)
assert response.ok
def upsert_multi_value_payload(collection_name):
points = [
{"id": 9000 + i, "vector": [0.0, 0.0, 1.0, 1.0], "payload": {"mkey": ["a"]}}
for i in range(100)
] + [
{"id": 9100 + i, "vector": [0.0, 0.0, 1.0, 0.0], "payload": {"mkey": ["a", "b"]}}
for i in range(10)
]
response = request_with_validation(
api="/collections/{collection_name}/points",
method="PUT",
path_params={"collection_name": collection_name},
query_params={"wait": "true"},
body={"points": points},
)
assert response.ok
def upsert_doc_points(collection_name, docs=50):
points = [
{"id": i, "vector": [1.0, 0.0, 0.0, 0.0], "payload": {"body": f"doc body {i}"}}
for i in range(100)
]
response = request_with_validation(
api="/collections/{collection_name}/points",
method="PUT",
path_params={"collection_name": collection_name},
query_params={"wait": "true"},
body={"points": points},
)
assert response.ok
@pytest.fixture(autouse=True, scope="module")
def setup(on_disk_vectors, collection_name, lookup_collection_name):
basic_collection_setup(collection_name=collection_name, on_disk_vectors=on_disk_vectors)
upsert_chunked_docs(collection_name=collection_name)
upsert_points_with_array_fields(collection_name=collection_name)
upsert_with_heterogenous_fields(collection_name=collection_name)
upsert_multi_value_payload(collection_name=collection_name)
basic_collection_setup(collection_name=lookup_collection_name, on_disk_vectors=on_disk_vectors)
upsert_doc_points(collection_name=lookup_collection_name)
yield
drop_collection(collection_name=collection_name)
drop_collection(collection_name=lookup_collection_name)
def test_search_with_multiple_groups(collection_name):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [0.0, 0.0, 1.0, 1.0],
"limit": 2,
"with_payload": True,
"group_by": "mkey",
"group_size": 2,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 2
assert groups[0]["id"] == "a"
assert groups[1]["id"] == "b"
def test_search(collection_name):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 10,
"with_payload": True,
"group_by": "docId",
"group_size": 3,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 10
for g in groups:
assert len(g["hits"]) == 3
for h in g["hits"]:
assert h["payload"]["docId"] == g["id"]
def test_recommend(collection_name):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": {
"recommend": {
"positive": [5, 10, 15],
"negative": [6, 11, 16],
}
},
"limit": 10,
"with_payload": True,
"group_by": "docId",
"group_size": 3,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 10
for g in groups:
assert len(g["hits"]) == 3
for h in g["hits"]:
assert h["payload"]["docId"] == g["id"]
def test_with_vectors(collection_name):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 5,
"with_payload": True,
"with_vector": True,
"group_by": "docId",
"group_size": 3,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 5
for g in groups:
assert len(g["hits"]) == 3
for h in g["hits"]:
assert h["payload"]["docId"] == g["id"]
assert h["vector"] == [1.0, 0.0, 0.0, 0.0]
def test_inexistent_group_by(collection_name):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 10,
"with_payload": True,
"with_vector": True,
"group_by": "inexistentDocId",
"group_size": 3,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 0
def search_array_group_by(collection_name: str, group_by: str):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [0.0, 1.0, 0.0, 0.0],
"limit": 6,
"with_payload": True,
"group_by": group_by,
"group_size": 3,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 6
group_ids = [g["id"] for g in groups]
for i in range(3):
assert f"valid_{i}" in group_ids
assert f"valid_too_{i}" in group_ids
def test_multi_value_group_by(collection_name):
search_array_group_by(collection_name, "multiId")
search_array_group_by(collection_name, "multiId[]")
def test_groups_by_heterogenous_fields(collection_name):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [0.0, 0.0, 1.0, 0.0],
"limit": 10,
"with_payload": True,
"group_by": "heterogenousId",
"group_size": 3,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
group_ids = [g["id"] for g in groups]
# Expected group ids are: ['c', 3, 1, 123, 2, 'string', 'b', 'a']
assert len(groups) == 8
assert "c" in group_ids
assert 3 in group_ids
assert 1 in group_ids
assert 123 in group_ids
assert 2 in group_ids
assert "string" in group_ids
assert "b" in group_ids
assert "a" in group_ids
lookup_params = [
pytest.param(fixture_ref(lookup_collection_name), id="string name"),
pytest.param({"collection": fixture_ref(lookup_collection_name)}, id="only collection name"),
pytest.param(
{
"collection": fixture_ref(lookup_collection_name),
"with_payload": True,
"with_vectors": False,
},
id="explicit with_payload and with_vectors",
)
]
def assert_group_with_default_lookup(group, group_size=3):
assert group["hits"]
assert len(group["hits"]) == group_size
assert group["lookup"]
assert group["id"] == group["lookup"]["id"]
lookup = group["lookup"]
assert lookup["payload"]
assert not lookup.get("vector")
@parametrize("with_lookup", lookup_params, auto_refs=True)
def test_search_groups_with_lookup(collection_name, with_lookup):
with_lookup = jsons.load(jsons.dump(with_lookup))
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 10,
"with_payload": True,
"group_by": "docId",
"group_size": 3,
"with_lookup": with_lookup,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 10
for group in groups:
assert_group_with_default_lookup(group, 3)
@parametrize("with_lookup", lookup_params)
def test_recommend_groups_with_lookup(request, collection_name, with_lookup):
#with_lookup["collection"] = str(request.getfixturevalue('lookup_collection_name'))
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": {
"recommend": {
"positive": [5, 10, 15],
"negative": [6, 11, 16],
}
},
"limit": 10,
"with_payload": True,
"group_by": "docId",
"group_size": 3,
"with_lookup": jsons.dump(with_lookup),
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 10
for group in groups:
assert_group_with_default_lookup(group, 3)
@parametrize(
"with_lookup",
[
pytest.param(
{
"collection": fixture_ref(lookup_collection_name),
"with_payload": False,
"with_vectors": False,
},
id="with_payload and with_vectors",
),
pytest.param(
{
"collection": fixture_ref(lookup_collection_name),
"with_payload": False,
"with_vector": False,
},
id="with_vector is alias of with_vectors",
),
]
)
def test_search_groups_with_lookup_without_payload_nor_vectors(collection_name, with_lookup):
with_lookup = jsons.load(jsons.dump(with_lookup))
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 10,
"with_payload": True,
"group_by": "docId",
"group_size": 3,
"with_lookup": with_lookup,
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 10
for group in groups:
assert group["hits"]
assert len(group["hits"]) == 3
assert group["lookup"]
assert group["id"] == group["lookup"]["id"]
lookup = group["lookup"]
assert not lookup.get("payload")
assert not lookup.get("vector")
def test_search_groups_lookup_with_non_existing_collection(collection_name):
non_existing_collection = "non_existing_collection"
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 10,
"with_payload": True,
"group_by": "docId",
"group_size": 3,
"with_lookup": {
"collection": non_existing_collection,
"with_payload": True,
"with_vector": True,
},
},
)
assert response.status_code == 404
assert (
f"Collection {non_existing_collection} not found"
in response.json()["status"]["error"]
)
def test_search_groups_with_full_lookup(collection_name, lookup_collection_name):
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 10,
"with_payload": True,
"group_by": "docId",
"group_size": 3,
"with_lookup": {
"collection": lookup_collection_name,
"with_payload": True,
"with_vector": True,
},
},
)
assert response.ok
groups = response.json()["result"]["groups"]
assert len(groups) == 10
for group in groups:
assert group["hits"]
assert len(group["hits"]) == 3
assert group["lookup"]
assert group["id"] == group["lookup"]["id"]
lookup = group["lookup"]
assert lookup["payload"]
assert lookup["vector"]
def test_query_groups_missing_lookup_from_collection(collection_name):
missing_collection = "missing_lookup_from_collection"
lookup_from = {"collection": missing_collection, "vector": "default"}
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": [1.0, 0.0, 0.0, 0.0],
"limit": 10,
"group_by": "docId",
"group_size": 3,
"lookup_from": lookup_from,
},
)
assert response.status_code == 404, response.text
assert missing_collection in response.json()["status"]["error"]
response = request_with_validation(
api="/collections/{collection_name}/points/query/groups",
method="POST",
path_params={"collection_name": collection_name},
body={
"query": {"recommend": {"positive": [[1.0, 0.0, 0.0, 0.0]]}},
"limit": 10,
"group_by": "docId",
"group_size": 3,
"lookup_from": lookup_from,
},
)
assert response.status_code == 404, response.text
assert missing_collection in response.json()["status"]["error"]